Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change thresholds on LED and FEStatus Quality plots ECAL DQM #45429

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Change thresholds on LED and FEStatus Quality plots ECAL DQM #45429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53affd1
Disable quality cuts on LED quality plot
abhih1 Jul 11, 2024
5c43000
Change FEStatus quality threshold
abhih1 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DQM/EcalMonitorClient/interface/RawDataClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace ecaldqm {

private:
void setParams(edm::ParameterSet const&) override;

int minEvents_;
float synchErrThresholdFactor_;
};

Expand Down
4 changes: 3 additions & 1 deletion DQM/EcalMonitorClient/python/RawDataClient_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
from DQM.EcalMonitorTasks.RawDataTask_cfi import ecalRawDataTask

synchErrThresholdFactor = 1.
minEvents = 400

ecalRawDataClient = cms.untracked.PSet(
params = cms.untracked.PSet(
minEvents = cms.untracked.int32(minEvents),
synchErrThresholdFactor = cms.untracked.double(synchErrThresholdFactor)
),
sources = cms.untracked.PSet(
Expand All @@ -20,7 +22,7 @@
kind = cms.untracked.string('TH2F'),
otype = cms.untracked.string('Ecal3P'),
btype = cms.untracked.string('SuperCrystal'),
description = cms.untracked.string('Summary of the raw data (DCC and front-end) quality. A channel is red if it has nonzero events with FE status that is different from any of ENABLED, DISABLED, SUPPRESSED, FIFOFULL, FIFOFULL_L1ADESYNC, and FORCEDZS. A FED can also go red if its number of L1A desynchronization errors is greater than ' + str(synchErrThresholdFactor) + ' * log10(total entries).')
description = cms.untracked.string('Summary of the raw data (DCC and front-end) quality. A channel is red if it has '+ str(minEvents)+' or more events with FE status that is different from any of ENABLED, DISABLED, SUPPRESSED, FIFOFULL, FIFOFULL_L1ADESYNC, and FORCEDZS. A FED can also go red if its number of L1A desynchronization errors is greater than ' + str(synchErrThresholdFactor) + ' * log10(total entries).')
),
ErrorsSummary = cms.untracked.PSet(
path = cms.untracked.string('%(subdet)s/%(prefix)sSummaryClient/%(prefix)sSFT front-end status errors summary'),
Expand Down
6 changes: 5 additions & 1 deletion DQM/EcalMonitorClient/src/LedClient.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ namespace ecaldqm {

float aRmsThr(sqrt(pow(aMean * toleranceAmpRMSRatio_, 2) + pow(3., 2)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable seems to be unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but if that's commented out it will complain about other variables like toleranceAmpRMSRatio_, which would need to be commented out here as well as the header and .py files. And since this is supposed to be a temporary disabling of the cuts and would need to be reused in the future, I left it untouched to keep the changes to a minimum.


//Temporarily disabling all cuts on LED Quality plot.
qItr->setBinContent(doMask ? kMGood : kGood);

/*
EcalScDetId scid = EEDetId(id).sc(); //Get the Endcap SC id for the given crystal id.
//For the known bad Supercrystals in the SClist, bad quality flag is only set based on the amplitude RMS
Expand All @@ -180,7 +184,7 @@ namespace ecaldqm {
qItr->setBinContent(doMask ? kMBad : kBad);
else
qItr->setBinContent(doMask ? kMGood : kGood);
}
}*/
}

towerAverage_(meQualitySummary, meQuality, 0.2);
Expand Down
5 changes: 3 additions & 2 deletions DQM/EcalMonitorClient/src/RawDataClient.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@

namespace ecaldqm {

RawDataClient::RawDataClient() : DQWorkerClient(), synchErrThresholdFactor_(0.) {
RawDataClient::RawDataClient() : DQWorkerClient(), minEvents_(0), synchErrThresholdFactor_(0.) {
qualitySummaries_.insert("QualitySummary");
}

void RawDataClient::setParams(edm::ParameterSet const& _params) {
minEvents_ = _params.getUntrackedParameter<int>("minEvents");
synchErrThresholdFactor_ = _params.getUntrackedParameter<double>("synchErrThresholdFactor");
}

Expand Down Expand Up @@ -57,7 +58,7 @@ namespace ecaldqm {
for (unsigned iS(0); iS < nFEFlags; iS++) {
float entries(sFEStatus.getBinContent(getEcalDQMSetupObjects(), id, iS + 1));
towerEntries += entries;
if (entries > 0. && iS != Enabled && iS != Suppressed && iS != ForcedFullSupp && iS != FIFOFull &&
if (entries > minEvents_ && iS != Enabled && iS != Suppressed && iS != ForcedFullSupp && iS != FIFOFull &&
iS != ForcedZS)
towerStatus = doMask ? kMBad : kBad;
}
Expand Down