[DQM] Fix Warning: move the unused code in the comment where it is needed

[smuzaffar]

This change should fix the warning [a]. aRmsThr and intensity are needed only in the code which has been commented out, so the PR proposes to move these in the comment section too

[a]

• https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_ROOT6_X_2024-07-16-2300/DQM/EcalMonitorClient
• https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_CLANG_X_2024-07-17-1700/DQM/EcalMonitorClient

  src/DQM/EcalMonitorClient/src/LedClient.cc:162:15: warning: variable 'intensity' set but not used [-Wunused-but-set-variable]
   162 |         float intensity(aMean / expectedAmplitude_[wlItr->second]);
      |               ^
  src/DQM/EcalMonitorClient/src/LedClient.cc:166:15: warning: unused variable 'aRmsThr' [-Wunused-variable]
   166 |         float aRmsThr(sqrt(pow(aMean * toleranceAmpRMSRatio_, 2) + pow(3., 2)));

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test with cms-sw/cms-bot#2296

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45482/40947

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• DQM/EcalMonitorClient (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1aaee/40452/summary.html
COMMIT: ec21e57
CMSSW: CMSSW_14_1_X_2024-07-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45482/40452/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[smuzaffar]

please test with cms-sw/cms-bot#2296

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45482/40948

[cmsbuild]

Pull request #45482 was updated. @antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[smuzaffar]

@cms-sw/dqm-l2 , can you please review this PR? This fixes the compilation warning about unused variable. #45429 PR had commented out some code which was using this variable. This change move the unused variable variable in the comment where it is needed. This should fix the compilation warning in the 14.1.X IBs ( I think we also need to backport it to 14.0.X)

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1aaee/40453/summary.html
COMMIT: e0ce869
CMSSW: CMSSW_14_1_X_2024-07-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45482/40453/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345094
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345068
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

• @smuzaffar , could you please also make its backport PR to 14_0_X . thanks in advance!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

* @smuzaffar , could you please also make its backport PR to `14_0_X` . thanks in advance!

done #45494

[smuzaffar]

@cms-sw/orp-l2 , can you please review and approve this PR? this should the last remaining warning for 14.1.X default IBs

[rappoccio]

+1