Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR warning detection logic #2296

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix PR warning detection logic #2296

merged 2 commits into from
Jul 17, 2024

Conversation

smuzaffar
Copy link
Contributor

Fix PR warnings detection logic

  • Look for : warning #NN-D: type nvcc warnings
  • Fix logic for searching CMSSW warning: New build rules use relative path so CMSSW_version is not part of warning

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = DataFormats/HcalDigi,RecoTracker/PixelSeeding,L1Trigger/Phase2L1GMT

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a3a0f/40441/summary.html
COMMIT: 070e306
CMSSW: CMSSW_14_1_X_2024-07-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2296/40441/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #2296 was updated.

@smuzaffar
Copy link
Contributor Author

+externals

Once merged this will start failing PRs tests where PR touches a file(s) with warnings in it.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen: This PR was tested with cms-sw/cmssw#45481, please check if they should be merged together

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a3a0f/40449/summary.html
COMMIT: 7628fd7
CMSSW: CMSSW_14_1_X_2024-07-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2296/40449/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit b66198c into master Jul 17, 2024
11 checks passed
@smuzaffar smuzaffar deleted the pr-warnings branch September 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants