Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change thresholds on LED and FEStatus Quality plots ECAL DQM [14_0_X] #45430

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Jul 11, 2024

PR description:

This PR does the following:

  1. Disables all cuts on the LED Quality plot until the experts can tune the parameters.
  2. Adds a cut on minimum no.of events to turn the FEStatus quality to RED, to reduce false alarm on transient issues.

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 14_0_X used in production at the moment.
Master PR is #45429

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2024

A new Pull Request was created by @abhih1 for CMSSW_14_0_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jul 12, 2024

backport of #45429

@tjavaid
Copy link

tjavaid commented Jul 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-787095/40352/summary.html
COMMIT: a3bef8c
CMSSW: CMSSW_14_0_X_2024-07-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45430/40352/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Jul 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 32a8a37 into cms-sw:CMSSW_14_0_X Jul 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants