Migrate `assert` to to `ALPAKA_ASSERT_ACC` [14.0.x] #44805

fwyzard · 2024-04-22T21:01:01Z

PR description:

Migrate assert() to ALPAKA_ASSERT_ACC().

PR validation:

None.

Backport of #44802 to 14.0.x for data taking.

fwyzard · 2024-04-22T21:01:13Z

backport #44802

fwyzard · 2024-04-22T21:01:28Z

+heterogeneous

fwyzard · 2024-04-22T21:01:32Z

enable gpu

cmsbuild · 2024-04-22T21:01:33Z

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

CondFormats/SiPixelObjects (alca, db)
DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
DataFormats/VertexSoA (heterogeneous, reconstruction)
HeterogeneousCore/AlpakaInterface (heterogeneous)
RecoLocalCalo/EcalRecProducers (reconstruction)
RecoLocalTracker/SiPixelRecHits (reconstruction)
RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @fwyzard, @makortel, @francescobrivio, @jfernan2, @perrotta, @mandrenguyen, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks.
@tvami, @threus, @GiacomoSguazzoni, @makortel, @mtosi, @rovere, @argiro, @thomreis, @apsallid, @rsreds, @JanChyczynski, @JanFSchulte, @wang0jin, @tocheng, @missirol, @youyingli, @mmusich, @dkotlins, @mroguljic, @VinInn, @PonIlya, @tsusa, @seemasharmafnal, @VourMa, @felicepantaleo, @yuanchao, @dgulhan, @ferencek, @ReyerBand, @gpetruc, @rchatter this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

Backported from Migrate assert to to ALPAKA_ASSERT_ACC #44802

cmsbuild · 2024-04-22T21:01:33Z

cms-bot internal usage

fwyzard · 2024-04-22T21:01:36Z

please test

fwyzard · 2024-04-22T21:03:31Z

urgent

@cms-sw/orp-l2 please include this PR in the next CMSSW 14.0.x full release.
It is needed to support centrally enabling/disabling assertions in Alpaka GPU code, to evaluate the trade-off between improved error messages and faster HLT throughput.

cmsbuild · 2024-04-23T00:53:17Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39011/summary.html
COMMIT: 198c126
CMSSW: CMSSW_14_0_X_2024-04-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39011/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39011/git-merge-result

RelVals

136.88811

----- Begin Fatal Exception 23-Apr-2024 00:33:10 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/UParTAK4/PUPPI/V00/UParTAK4.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 23-Apr-2024 00:33:11 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/UParTAK4/PUPPI/V00/UParTAK4.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 23-Apr-2024 00:33:11 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/UParTAK4/PUPPI/V00/UParTAK4.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39011/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02834/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-04-22-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 191
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39549
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-04-23T05:49:30Z

+1
errors are clearly unrelated to this PR

fwyzard · 2024-04-23T06:16:56Z

please test

The CMSSW_14_0_X_2024-04-22-2300 IB is hopefully in a better state.

cmsbuild · 2024-04-23T09:50:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f81a9/39015/summary.html
COMMIT: 198c126
CMSSW: CMSSW_14_0_X_2024-04-22-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44805/39015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 16 lines from the logs
Reco comparison results: 57 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3319088
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3319059
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 33 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 1096
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 38644
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

perrotta · 2024-04-23T15:12:28Z

+1

Identical to the PR in the master branch
This being technical, even if the master is not yet tested in IB, I can sign for alca/db: then the release managers will decide when to merge

cmsbuild · 2024-04-23T15:12:56Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-04-24T11:00:14Z

+1

fwyzard added 5 commits April 22, 2024 22:57

Migrate assert() to ALPAKA_ASSERT_ACC()

b5c7e26

Clean up comments

4fc762b

Update test to use once_per_block

e08a9a8

Migrate assert() to ALPAKA_ASSERT_ACC()

5f962ba

Migrate assert() to ALPAKA_ASSERT_ACC()

198c126

cmsbuild added this to the CMSSW_14_0_X milestone Apr 22, 2024

cmsbuild added reconstruction-pending alca-pending db-pending pending-signatures tests-pending orp-pending backport heterogeneous-pending tracking trk labels Apr 22, 2024

cmsbuild added tests-started heterogeneous-approved and removed tests-pending heterogeneous-pending labels Apr 22, 2024

cmsbuild added the urgent label Apr 22, 2024

cmsbuild removed the tests-started label Apr 23, 2024

cmsbuild added the tests-rejected label Apr 23, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 23, 2024

cmsbuild added tests-started and removed tests-rejected labels Apr 23, 2024

cmsbuild added tests-approved backport-ok and removed tests-started backport labels Apr 23, 2024

cmsbuild added alca-approved fully-signed db-approved and removed alca-pending db-pending pending-signatures labels Apr 23, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 24, 2024

cmsbuild merged commit 222fc6a into cms-sw:CMSSW_14_0_X Apr 24, 2024
13 checks passed

fwyzard deleted the migrate_to_ALPAKA_ASSERT_ACC_140x branch June 13, 2024 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `assert` to to `ALPAKA_ASSERT_ACC` [14.0.x] #44805

Migrate `assert` to to `ALPAKA_ASSERT_ACC` [14.0.x] #44805

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

cmsbuild commented Apr 22, 2024 •

edited

Loading

cmsbuild commented Apr 22, 2024 •

edited

Loading

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

cmsbuild commented Apr 23, 2024

mandrenguyen commented Apr 23, 2024

fwyzard commented Apr 23, 2024 •

edited

Loading

cmsbuild commented Apr 23, 2024

perrotta commented Apr 23, 2024

cmsbuild commented Apr 23, 2024

antoniovilela commented Apr 24, 2024

Migrate assert to to ALPAKA_ASSERT_ACC [14.0.x] #44805

Migrate assert to to ALPAKA_ASSERT_ACC [14.0.x] #44805

Conversation

fwyzard commented Apr 22, 2024

PR description:

PR validation:

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

cmsbuild commented Apr 22, 2024 • edited Loading

cmsbuild commented Apr 22, 2024 • edited Loading

fwyzard commented Apr 22, 2024

fwyzard commented Apr 22, 2024

cmsbuild commented Apr 23, 2024

RelVals

RelVals-INPUT

GPU Comparison Summary

mandrenguyen commented Apr 23, 2024

fwyzard commented Apr 23, 2024 • edited Loading

cmsbuild commented Apr 23, 2024

Comparison Summary

GPU Comparison Summary

perrotta commented Apr 23, 2024

cmsbuild commented Apr 23, 2024

antoniovilela commented Apr 24, 2024

Migrate `assert` to to `ALPAKA_ASSERT_ACC` [14.0.x] #44805

Migrate `assert` to to `ALPAKA_ASSERT_ACC` [14.0.x] #44805

cmsbuild commented Apr 22, 2024 •

edited

Loading

cmsbuild commented Apr 22, 2024 •

edited

Loading

fwyzard commented Apr 23, 2024 •

edited

Loading