Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer [14.0.x]

[fwyzard]

PR description:

Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer while looking for neighbours.

Fixes #44789 .

PR validation:

Enabling range checks shows that PFRecHitTopologyESProducer no longer accesses an invalid SoA index.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44790 to CMSSW 14.0.5-patch for data taking, in case a new patch release will be built.

[fwyzard]

type bugfix

[fwyzard]

type pf

[fwyzard]

backport #44790

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @missirol, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer #44790

[cmsbuild]

cms-bot internal usage

[fwyzard]

assign heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fwyzard]

+heterogeneous

[fwyzard]

urgent

Please include this PR in the next online (full) release.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dac268/38981/summary.html
COMMIT: c2d68bc
CMSSW: CMSSW_14_0_X_2024-04-21-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44793/38981/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @AdrianoDee [14_0_X] Allow Runtime Number of Hits for Alpaka Pixel Reconstruction #44774

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dac268/38981/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dac268/38981/git-merge-result

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3318486
• DQMHistoTests: Total failures: 1355
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3317111
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[rappoccio]

In the interest of time I've merged this even though the main branch has not completed. Let's see if this one completes and then we can do the bare backport in #44791.

[fwyzard]

thanks