Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer [14.0.5-patch]

[fwyzard]

PR description:

Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer while looking for neighbours.

Fixes #44789 .

PR validation:

Enabling range checks shows that PFRecHitTopologyESProducer no longer accesses an invalid SoA index.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44790 to CMSSW 14.0.5-patch for data taking, in case a new patch release will be built.

[fwyzard]

backport #44790

[fwyzard]

type bugfix

[fwyzard]

assign heterogeneous

[fwyzard]

+heterogeneous

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

• Geometry/CommonTopologies (geometry)
• RecoEgamma/EgammaHLTProducers (hlt)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoParticleFlow/PFRecHitProducer (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)

@bsunanda, @mdhildreth, @cmsbuild, @Martin-Grunewald, @civanch, @mmusich, @Dr15Jones, @mandrenguyen, @makortel, @jfernan2 can you please review it and eventually sign? Thanks.
@ferencek, @Fedespring, @tvami, @varuns23, @mmusich, @VourMa, @seemasharmafnal, @afiqaize, @ram1123, @felicepantaleo, @Prasant1993, @gpetruc, @HuguesBrun, @wang0jin, @sameasy, @silviodonato, @threus, @ReyerBand, @thomreis, @sobhatta, @valsdav, @GiacomoSguazzoni, @mroguljic, @rchatter, @cericeci, @missirol, @mmarionncern, @Sam-Harper, @hatakeyamak, @JanFSchulte, @dgulhan, @rovere, @VinInn, @dkotlins, @bsunanda, @mtosi, @argiro, @fabiocos, @tsusa, @jainshilpi, @lgray, @a-kapoor this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

• Backported from Skip invalid HCAL PF rechits in PFRecHitTopologyESProducer #44790

[cmsbuild]

cms-bot internal usage

[fwyzard]

type pf

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fwyzard]

urgent

Please include this PR in the next online (patch) release.

[mmusich]

This seems to drag unnecessary merge commits that introduce unneded signatures. Please fix

[fwyzard]

This seems to drag unnecessary merge commits that introduce unneded signatures. Please fix

This PR is based on CMSSW_14_0_5_patch2, which is the latest release available in the CMSSW_14_0_X series.

[mmusich]

This PR is based on CMSSW_14_0_5_patch2, which is the latest release available in the CMSSW_14_0_X series.

Thanks for changing the base branch.

[mmusich]

@cmsbuild please test

[mmusich]

Ok, it cannot be tested because there are no IB-s of this branch

[mmusich]

@cmsbuild, please abort

[mandrenguyen]

+1
I leave it to the release managers to decide what to do about the lack of tests.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_5_patchX IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

I merged the standard 14_0_X branch now, let's see if it succeeds in an IB and then will merge this tomorrow.

[antoniovilela]

In this case one relies on the tests & review performed in 14_0_X.

[antoniovilela]

merge