Reorganise alpaka kernel loop functions [14.0.x] #44714

fwyzard · 2024-04-11T15:28:07Z

PR description:

Reorganise the implementation of the Alpaka-based kernel loop functions.

Rename the implementation classes to CamelCase and move them to the detail namespace:

rename uniform_elements_along to detail::UniformElementsAlong
rename uniform_groups_along to detail::UniformGroupsAlong
rename uniform_group_elements_along to detail::UniformGroupElementsAlong
rename uniform_elements_nd to detail::UniformElementsND
rename independent_groups_along to detail::IndependentGroupsAlong
rename independent_group_elements_along to detail::IndependentGroupElementsAlong

Replace legacy loop names with the more explicit ones, in the cms::alpakatools namespace:

replace elements_with_stride(...) with uniform_elements(...)
replace blocks_with_stride(...) with uniform_groups(...)
replace elements_in_block(...) with uniform_group_elements(...)

Rename legacy function with the new names.

PR validation:

None.

Backport status:

Backport of #44712 to CMSSW 14.0.x.

In the cms::alpakatools namespace - replace elements_with_stride(...) with uniform_elements(...) - replace blocks_with_stride(...) with uniform_groups(...) - replace elements_in_block(...) with uniform_group_elements(...)

fwyzard · 2024-04-11T15:28:17Z

backport #44712

fwyzard · 2024-04-11T15:28:21Z

enable gpu

fwyzard · 2024-04-11T15:28:24Z

please test

cmsbuild · 2024-04-11T15:28:37Z

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

HeterogeneousCore/AlpakaInterface (heterogeneous)
HeterogeneousCore/AlpakaTest (heterogeneous)
RecoLocalCalo/EcalRecProducers (reconstruction)
RecoParticleFlow/PFClusterProducer (reconstruction)
RecoParticleFlow/PFRecHitProducer (reconstruction)

@jfernan2, @fwyzard, @mandrenguyen, @makortel can you please review it and eventually sign? Thanks.
@mmarionncern, @rovere, @wang0jin, @felicepantaleo, @hatakeyamak, @apsallid, @makortel, @missirol, @lgray, @sameasy, @ReyerBand, @argiro, @seemasharmafnal, @rchatter, @thomreis, @youyingli this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Reorganise alpaka kernel loop functions #44712

cmsbuild · 2024-04-11T15:28:37Z

cms-bot internal usage

cmsbuild · 2024-04-11T15:54:14Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02ae8c/38786/summary.html
COMMIT: 9e26825
CMSSW: CMSSW_14_0_X_2024-04-11-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44714/38786/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/libalpakaTestAtomicPairCounterROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestHistoContainerROCmAsync/libalpakaTestHistoContainerROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/libalpakaTestAtomicPairCounterROCmAsync_rocm.a': No such file or directory
cp: cannot stat 'tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestHistoContainerROCmAsync/libalpakaTestHistoContainerROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/libalpakaTestAtomicPairCounterROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1838: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestAtomicPairCounterROCmAsync/libalpakaTestAtomicPairCounterROCmAsync_rocm.a] Error 1
>> Deleted: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestHistoContainerROCmAsync/libalpakaTestHistoContainerROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1838: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestHistoContainerROCmAsync/libalpakaTestHistoContainerROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestIndependentKernelROCmAsync/libalpakaTestIndependentKernelROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestIndependentKernelROCmAsync/libalpakaTestIndependentKernelROCmAsync_rocm.a': No such file or directory

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package HeterogeneousCore/AlpakaTest
>> Entering Package RecoLocalCalo/EcalRecProducers
>> Entering Package RecoParticleFlow/PFClusterProducer
>> Entering Package RecoParticleFlow/PFRecHitProducer
>> Compile sequence completed for CMSSW CMSSW_14_0_X_2024-04-11-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-04-11-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package HeterogeneousCore/AlpakaInterface
Entering library rule at HeterogeneousCore/AlpakaInterface
>> Compiling  src/HeterogeneousCore/AlpakaInterface/src/Backend.cc

Rename classes to CamelCase and move them to the detail namespace: - uniform_elements_along to detail::UniformElementsAlong - uniform_groups_along to detail::UniformGroupsAlong - uniform_group_elements_along to detail::UniformGroupElementsAlong - uniform_elements_nd to detail::UniformElementsND - independent_groups_along to detail::IndependentGroupsAlong - independent_group_elements_along to detail::IndependentGroupElementsAlong Introduce helper functions with the old names.

cmsbuild · 2024-04-11T22:25:20Z

Pull request #44714 was updated. @mandrenguyen, @makortel, @cmsbuild, @jfernan2, @fwyzard can you please check and sign again.

fwyzard · 2024-04-11T22:26:37Z

please test

cmsbuild · 2024-04-12T05:41:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02ae8c/38799/summary.html
COMMIT: 4442472
CMSSW: CMSSW_14_0_X_2024-04-11-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44714/38799/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 86 lines to the logs
Reco comparison results: 40 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3308451
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3308428
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 39740
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 39720
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-04-12T07:14:05Z

+1

fwyzard · 2024-04-19T12:23:33Z

+heterogeneous

cmsbuild · 2024-04-19T12:23:54Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

fwyzard · 2024-04-22T17:44:19Z

@cms-sw/orp-l2 could you merge this for the next CMSSW 14.0.x release ?

rappoccio · 2024-04-22T17:56:49Z

+1

fwyzard added 2 commits April 3, 2024 23:14

Replace legacy loop names with the more explicit ones

b70e6e2

In the cms::alpakatools namespace - replace elements_with_stride(...) with uniform_elements(...) - replace blocks_with_stride(...) with uniform_groups(...) - replace elements_in_block(...) with uniform_group_elements(...)

Drop legacy loop names

f7c445c

cmsbuild added this to the CMSSW_14_0_X milestone Apr 11, 2024

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started backport heterogeneous-pending labels Apr 11, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 11, 2024

fwyzard force-pushed the alpaka_explicit_loop_names_140x branch from 9e26825 to 4442472 Compare April 11, 2024 22:25

cmsbuild added tests-pending and removed tests-rejected labels Apr 11, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 11, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2024

cmsbuild removed the reconstruction-pending label Apr 12, 2024

cmsbuild added the reconstruction-approved label Apr 12, 2024

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Apr 19, 2024

fwyzard mentioned this pull request Apr 19, 2024

Reorganise alpaka kernel loop functions #44712

Merged

cmsbuild added backport-ok and removed backport labels Apr 19, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 22, 2024

cmsbuild merged commit c176f86 into cms-sw:CMSSW_14_0_X Apr 22, 2024
13 checks passed

This was referenced Apr 22, 2024

[14.0.X] Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44512

Merged

Migrate assert to to ALPAKA_ASSERT_ACC [14.0.x] #44805

Merged

fwyzard deleted the alpaka_explicit_loop_names_140x branch June 13, 2024 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganise alpaka kernel loop functions [14.0.x] #44714

Reorganise alpaka kernel loop functions [14.0.x] #44714

fwyzard commented Apr 11, 2024 •

edited

Loading

fwyzard commented Apr 11, 2024

fwyzard commented Apr 11, 2024

fwyzard commented Apr 11, 2024

cmsbuild commented Apr 11, 2024 •

edited

Loading

cmsbuild commented Apr 11, 2024 •

edited

Loading

cmsbuild commented Apr 11, 2024

cmsbuild commented Apr 11, 2024

fwyzard commented Apr 11, 2024

cmsbuild commented Apr 12, 2024

jfernan2 commented Apr 12, 2024

fwyzard commented Apr 19, 2024

cmsbuild commented Apr 19, 2024

fwyzard commented Apr 22, 2024

rappoccio commented Apr 22, 2024

Reorganise alpaka kernel loop functions [14.0.x] #44714

Reorganise alpaka kernel loop functions [14.0.x] #44714

Conversation

fwyzard commented Apr 11, 2024 • edited Loading

PR description:

PR validation:

Backport status:

fwyzard commented Apr 11, 2024

fwyzard commented Apr 11, 2024

fwyzard commented Apr 11, 2024

cmsbuild commented Apr 11, 2024 • edited Loading

cmsbuild commented Apr 11, 2024 • edited Loading

cmsbuild commented Apr 11, 2024

Build

Clang Build

cmsbuild commented Apr 11, 2024

fwyzard commented Apr 11, 2024

cmsbuild commented Apr 12, 2024

Comparison Summary

GPU Comparison Summary

jfernan2 commented Apr 12, 2024

fwyzard commented Apr 19, 2024

cmsbuild commented Apr 19, 2024

fwyzard commented Apr 22, 2024

rappoccio commented Apr 22, 2024

fwyzard commented Apr 11, 2024 •

edited

Loading

cmsbuild commented Apr 11, 2024 •

edited

Loading

cmsbuild commented Apr 11, 2024 •

edited

Loading