Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14_0_X] Add Unified ParT to tau NanoAOD (Backport) #44723

Merged
merged 16 commits into from
Apr 22, 2024
Merged

[14_0_X] Add Unified ParT to tau NanoAOD (Backport) #44723

merged 16 commits into from
Apr 22, 2024

Conversation

lucasrussell01
Copy link
Contributor

@lucasrussell01 lucasrussell01 commented Apr 12, 2024 •
edited
Loading

PR description:

This PR is a Backport to 14_0_X, to add Unified ParT information to taus stored in NanoAOD.
-> These changes require this Backport PR from @AlexDeMoor to be merged #44660, based on the model in cms-data/RecoBTag-Combined#57

Added (for PUPPI jets):

  • UnifiedParT discriminators vs jets, electrons and muons,
  • Decay mode corresponding with the UnifiedParT tau node with the highest score,
  • Correction for tau pt,
  • Charge assignment confidence (signed),
  • UnifiedParT scores for individual decay-modes (normalised to the sum of the scores for all tau nodes).

Corresponding ParticleNet 2023 variables are stored for CHS jets.

Performance of UParT is described in: https://indico.cern.ch/event/1403350/contributions/5899772/attachments/2832957/4949984/UParT%202024%20-%20final%20results.pdf

Master PR: #44691

PR validation:

Tested successfully with NanoAOD workflow using CMSSW_14_0 RELVAL file, with pending PR UnifiedParT changes and model merged.

Distributions of UParT and PNet for taus compared here:
https://indico.cern.ch/event/1401414/contributions/5891063/attachments/2838625/4961188/UParT_Integration.pdf

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 12, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024 •
edited
Loading

A new Pull Request was created by @lucasrussell01 for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (reconstruction, xpog)

@jfernan2, @hqucms, @mandrenguyen, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@seemasharmafnal, @ahinzmann, @demuller, @AlexDeMoor, @schoef, @Senphy, @mbluj, @gouskos, @jdolen, @mmarionncern, @AnnikaStein, @andrzejnovak, @mariadalfonso, @hatakeyamak, @gpetruc, @nhanvtran, @jdamgov, @castaned, @gkasieczka, @azotz, @Ming-Yan, @rappoccio this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024 •
edited
Loading

cms-bot internal usage

@lucasrussell01 lucasrussell01 changed the title Cmssw 14 0 tau u par t backport [14_0_X] Add Unified ParT to tau NanoAOD (Backport) Apr 12, 2024
@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4224df/38831/summary.html
COMMIT: 6b8dbd8
CMSSW: CMSSW_14_0_X_2024-04-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44723/38831/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 140.023140.023_RunZeroBias2022B/step3_RunZeroBias2022B.log
  • 140.043140.043_RunZeroBias2022C/step3_RunZeroBias2022C.log
  • 135.4135.4_ZEEFS_13/step4_ZEEFS_13.log
Expand to see more relval errors ...

RelVals-INPUT

  • 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
  • 140.202140.202_RunJetMET2022D_reMINI/step2_RunJetMET2022D_reMINI.log
  • 13234.013234.0_TTbar_14TeV+2021FS/step2_TTbar_14TeV+2021FS.log
Expand to see more relval errors ...

@hqucms
Copy link
Contributor

hqucms commented Apr 16, 2024

test parameters:

@hqucms
Copy link
Contributor

hqucms commented Apr 16, 2024

please test

@hqucms
Copy link
Contributor

hqucms commented Apr 16, 2024

backport of #44691

@lucasrussell01 lucasrussell01 mentioned this pull request Apr 16, 2024
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4224df/38870/summary.html
COMMIT: b2a1298
CMSSW: CMSSW_14_0_X_2024-04-16-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44723/38870/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4224df/38870/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4224df/38870/git-merge-result

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 928 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3318556
  • DQMHistoTests: Total failures: 204
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3318332
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 45.55500000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 3.894 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 2.033 KiB Physics/NanoAODDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 50 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16281
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16246
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 41.489 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 3.894 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 2.033 KiB Physics/NanoAODDQM
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.702 2.593 0.109 ( +4.2% ) 3.91 5.13 -23.7% 2.179 2.174
2500.001 2.817 2.725 0.091 ( +3.4% ) 3.53 4.63 -23.9% 2.604 2.600
2500.002 2.763 2.671 0.093 ( +3.5% ) 3.66 4.82 -23.9% 2.590 2.591
2500.01 1.380 1.323 0.057 ( +4.3% ) 6.78 9.34 -27.4% 2.256 2.271
2500.011 1.831 1.746 0.086 ( +4.9% ) 3.68 5.20 -29.2% 2.430 2.452
2500.012 1.653 1.586 0.067 ( +4.2% ) 5.23 7.24 -27.8% 2.400 2.336
2500.1 2.276 2.263 0.013 ( +0.6% ) 5.05 5.16 -2.1% 1.997 2.063
2500.2 2.382 2.368 0.014 ( +0.6% ) 5.74 5.86 -2.1% 1.898 1.980
2500.21 1.215 1.203 0.012 ( +1.0% ) 4.20 4.22 -0.6% 2.211 2.263
2500.211 1.586 1.571 0.015 ( +1.0% ) 3.65 3.76 -2.9% 2.254 2.347
2500.3 2.149 2.134 0.015 ( +0.7% ) 11.30 11.83 -4.5% 1.980 1.975
2500.301 2.745 2.726 0.019 ( +0.7% ) 9.73 9.35 +4.1% 1.841 1.958
2500.31 1.280 1.284 -0.004 ( -0.3% ) 18.45 19.20 -3.9% 2.286 2.372
2500.311 1.677 1.678 -0.002 ( -0.1% ) 12.11 12.45 -2.7% 2.327 2.440
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.39 1.39 +0.3% 1.696 1.694
2500.313 1.568 1.568 0.000 ( +0.0% ) 6.99 6.47 +8.0% 1.047 1.046
2500.314 1.199 1.199 0.000 ( +0.0% ) 11.86 12.21 -2.9% 2.217 2.205
2500.315 1.798 1.800 -0.002 ( -0.1% ) 12.17 12.21 -0.3% 2.334 2.333
2500.316 3.254 3.123 0.131 ( +4.2% ) 1.98 2.19 -9.5% 2.130 2.158
2500.317 1.825 1.826 -0.001 ( -0.1% ) 11.93 12.05 -1.0% 2.162 2.158
2500.318 4.085 4.208 -0.124 ( -2.9% ) 5.11 4.99 +2.4% 2.125 2.199
2500.4 2.293 2.307 -0.014 ( -0.6% ) 11.17 11.35 -1.6% 1.911 1.880
2500.401 1.849 1.849 0.000 ( +0.0% ) 9.36 9.92 -5.7% 1.690 1.758
2500.402 2.861 2.874 -0.012 ( -0.4% ) 8.99 9.41 -4.4% 1.811 1.823
2500.403 5.385 5.183 0.202 ( +3.9% ) 1.38 1.57 -12.0% 1.801 1.921
2500.404 2.869 2.881 -0.012 ( -0.4% ) 8.97 9.54 -6.0% 1.879 1.918
2500.405 8.611 8.830 -0.219 ( -2.5% ) 3.34 3.24 +3.3% 1.892 1.949
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.35 15.57 -1.4% 1.565 1.616
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.54 9.65 -1.1% 1.658 1.653

@hqucms
Copy link
Contributor

hqucms commented Apr 16, 2024

+1

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild cmsbuild mentioned this pull request Apr 17, 2024
Merged
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44660

@hqucms
Copy link
Contributor

hqucms commented Apr 19, 2024

@cms-sw/orp-l2 Could you please merge this? Thanks!

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 69f4504 into cms-sw:CMSSW_14_0_X Apr 22, 2024
13 checks passed
This was referenced Apr 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed orp-approved reconstruction-approved requires-external tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasrussell01 @cmsbuild @mandrenguyen @hqucms @rappoccio