Fix maybe-uninitialized warning in MeasurementTrackerImpl::addPhase2Det

[iarspider]

Closes #42625

PR description:

Fixes maybe-uninitialized warning in MeasurementTrackerImpl::addPhase2Det as suggested by @makortel in #42625 (comment) .

PR validation:

Local build

[iarspider]

please test for CMSSW_13_3_CPP20_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42880/37018

ERROR: Build errors found during clang-tidy run.

RecoTracker/MeasurementDet/plugins/TkPhase2OTMeasurementDet.cc:11:29: error: field 'theDetConditions' will be initialized after field 'index_' [clang-diagnostic-reorder-ctor]
    : MeasurementDet(gdet), theDetConditions(&conditions), index_(0) {
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~
                            index_(0)                      theDetConditions(&conditions)
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42880/37019

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• RecoTracker/MeasurementDet (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_13_3_CPP20_X

[iarspider]

please test

[iarspider]

please test for CMSSW_13_3_CPP20_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9007a4/34930/summary.html
COMMIT: 9a3b9f4
CMSSW: CMSSW_13_3_X_2023-09-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42880/34930/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358320
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3358295
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[iarspider]

For CPP20, the failure also happens in IBs and doesn't seem to be related to this PR.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9007a4/34931/summary.html
COMMIT: 9a3b9f4
CMSSW: CMSSW_13_3_CPP20_X_2023-09-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42880/34931/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @wddgit Add unit test for SiStripApproximateClusterCollection format #42859
• @abhih1 Enable Laser 4 plots in ECAL DQM #42805
• @Dr15Jones Extend AllocMonitor #42814
• @swagata87 Addition of SingleEleNonIso HLT path of pT threshold 115 GeV to Phase2 HLT menu #42819
• @thomreis ECAL - Add dummy collections to ECAL GPU unpacker #42844
• @nurfikri89 [NanoAOD, JMENano] Updates for Nano and JMENano #42728
• @guitargeek Make enum to int conversion in SiStripRawToDigiUnpacker.cc explicit #42839
• @Dr15Jones Removed unused IDVectorMap class #42847
• @Dr15Jones Changed FailPath/SkipEvent to TryToContinue [Configuration] #42770
• @swagata87 Fixing bug in a photon path in Phase2 HLT #42870
• @Dr15Jones Changed FailPath/SkipEvent to TryToContinue [DPG] #42772
• @missirol update HLT selection for HI mode in sistrip and l1tstage2 online-DQM clients #42803
• @mmusich minimal fixes to run Phase2 patatrack pixel only workflows without using phase-1 pixel conditions #42830
• @abhih1 Fix bug in defining bin edges of TH2F plots in ECAL DQM #42857
• @mmusich Fix PixelCountFilter and introduce PixelOccupancyFilter #42849
• @mmusich Add 2D comparison histograms to SiStripMonitorApproximateCluster #42852
• @mmusich fix commented section of EDAnalyzer::fillDescriptions skeleton, such that it can actually compile #42846

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9007a4/34931/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9007a4/34931/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestSiStripApproximateClusterCollection had ERRORS

Comparison Summary

Summary:

• You potentially added 8388 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 18465 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358044
• DQMHistoTests: Total failures: 57590
• DQMHistoTests: Total nulls: 1801
• DQMHistoTests: Total successes: 3298631
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 34.246 KiB( 49 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 3.478 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 13234.0,... ): 2.476 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[antoniovilela]

merge