Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD, JMENano] Updates for Nano and JMENano #42728

Merged

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Sep 6, 2023

PR description:

This PR aims to add changes related to NanoAOD, JMENanoAOD and ensuring consistency of PuppiProducer instances when processing MiniAODs for production and analysis. The following changes are made:

NanoAOD
These changes are intended to be for the next NanoAOD campaign (v13?)

  • Add missing RUN3WINTER22PUPPIrunsBCDEprompt JetID version for jets.
  • Add (puppi-weighted) charged and neutral multiplicities for jets.
  • Add HF energy fractions for AK4 jets.
  • Add energy fractions for AK8 jets.
  • Add jet area for subjets. Fix the documentation of subjet collection.

JMENanoAOD

  • Add Run-3 JetIDs.
  • Remove AK8CHS jet collection.
  • Reduce content for AK4CHS collection by removing PUID/QGL tagger inputs and most flavour-tagging discriminants.
  • Increase pT thresholds for AK4CHS, AK4GEN, AK8GEN.
  • Rename some branches.

PuppiProducer consistency

  • Improve setupPuppiForPackedPF() in jetTools.py by adding packedpuppiNoLep instance.
  • In runMETCorrectionsAndUncertainties.py, make it optional to provide a different PuppiProducer module label rather than stick to a hard-coded label (puppiNoLep). Set the previously hard-coded label as the default option.

PR validation:

  • passes the standard runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
  • passes the following NanoAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.0,2500.001,2500.002,2500.01,2500.011,2500.012,2500.1,2500.2,2500.21,2500.3,2500.31,2500.4

If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to earlier 13_X releases for Run-3 JMENano production but not 13_0_X because there is already the ongoing 2023 NanoAOD production.

…GL input variables and most b-taggers for AK4CHS. Drop AK8 CHS jets.
… hard-coded label. 'puppiNoLep' is set as the default value.
… clustering. 'puppi' is set as the default value.
…ts below some pt thresholds have reduced information stored (e.g multiplicities)
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42728/36820

This was referenced Sep 18, 2023
@simonepigazzini
Copy link
Contributor

Hi @nurfikri89, do you plan to add the MINI from MINI functions in this PR?

@nurfikri89
Copy link
Contributor Author

Hi @nurfikri89, do you plan to add the MINI from MINI functions in this PR?

Hi @simonepigazzini, no I will follow up with a separate PR. Given the latest plan to reMini 2022 samples with 13X, we can already request a JMENano production for 2022 and 2023 after this PR is merged.

@simonepigazzini
Copy link
Contributor

+1

@simonepigazzini
Copy link
Contributor

simonepigazzini commented Sep 25, 2023

type nanoaod

(does this work?) -> nope

@mandrenguyen
Copy link
Contributor

please test
Argh, i'm sorry I can't see the test results anymore.
Hopefully reco should sign quickly.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f8664/34903/summary.html
COMMIT: f3b31fa
CMSSW: CMSSW_13_3_X_2023-09-26-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42728/34903/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 149 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357997
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 34.25 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 3.478 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 2.476 KiB Physics/NanoAODDQM
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15715
  • DQMHistoTests: Total failures: 1142
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 14573
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26.278000000000002 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 2.896 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 1.894 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.311,... ): 2.476 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.3,... ): 3.478 KiB Physics/NanoAODDQM
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.469 2.469 0.000 ( +0.0% ) 5.24 5.27 -0.6% 2.108 2.099
2500.001 2.611 2.611 0.000 ( +0.0% ) 4.78 4.74 +0.8% 2.491 2.492
2500.002 2.522 2.522 0.000 ( +0.0% ) 4.92 4.94 -0.5% 2.479 2.485
2500.01 1.264 1.264 0.000 ( +0.0% ) 9.65 9.61 +0.5% 2.160 2.208
2500.011 1.634 1.634 0.000 ( +0.0% ) 5.20 5.20 +0.2% 2.310 2.329
2500.012 1.517 1.517 0.000 ( +0.0% ) 7.42 7.47 -0.7% 2.224 2.236
2500.1 2.126 2.126 0.000 ( +0.0% ) 5.34 5.37 -0.5% 1.950 2.032
2500.2 2.237 2.237 0.000 ( +0.0% ) 6.13 6.17 -0.7% 1.847 1.918
2500.21 1.125 1.125 -0.000 ( -0.0% ) 4.38 4.39 -0.1% 2.096 2.139
2500.211 1.479 1.479 0.000 ( +0.0% ) 3.85 3.84 +0.1% 2.133 2.187
2500.3 1.995 1.977 0.019 ( +0.9% ) 13.02 13.00 +0.1% 1.829 1.843
2500.31 1.201 1.190 0.011 ( +0.9% ) 20.48 20.87 -1.9% 2.178 2.280
2500.311 1.579 1.565 0.014 ( +0.9% ) 14.53 14.30 +1.6% 2.216 2.252
2500.4 1.995 1.977 0.019 ( +0.9% ) 13.14 13.02 +0.9% 1.851 1.914

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f3dfef0 into cms-sw:master Sep 26, 2023
cmsbuild added a commit that referenced this pull request Oct 11, 2023
…nanoDev_jmeNanoV11

[NanoAOD, JMENano] Backport of #42728 (Updates for Nano and JMENano), #42670 (Fix typos in jetsAK4 CHS and Puppi tables) and #42898 to 13_2_X
@nurfikri89 nurfikri89 deleted the from133X_202309042300_nanoDev_jmeNanoV11 branch February 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants