[JMENano] Update taggers for AK4 Puppi and CHS #42898

nurfikri89 · 2023-09-27T19:45:17Z

PR description:

This PR updates the taggers for AK4 Puppi and CHS jets in JMENano production. All the relevant taggers for AK4 Puppi jets are set to be computed for the newly reclustered collection and only one tagger is made available for AK4 CHS jets (since it is a backup collection). The updates did not make it in time for #42728.

PR validation:

passes the standard runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 13_2_X for 2022 & 2023 JMENano samples production campaign. Probably can be included in #42887 once this PR is merged?

cmsbuild · 2023-09-27T19:53:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42898/37033

This PR adds an extra 24KB to repository

cmsbuild · 2023-09-27T19:53:45Z

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@simonepigazzini, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

simonepigazzini · 2023-09-28T09:25:35Z

enable nano

simonepigazzini · 2023-09-28T09:25:39Z

please test

cmsbuild · 2023-09-28T18:03:05Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ace32/34959/summary.html
COMMIT: 917feb0
CMSSW: CMSSW_13_3_X_2023-09-28-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42898/34959/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3358320
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3358298
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15925
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15925
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.469	2.469	0.000 ( +0.0% )	5.32	5.35	-0.6%	2.098	2.176
2500.001	2.611	2.611	0.000 ( +0.0% )	4.73	4.79	-1.1%	2.480	2.615
2500.002	2.522	2.522	0.000 ( +0.0% )	4.90	4.89	+0.2%	2.465	2.588
2500.01	1.264	1.264	0.000 ( +0.0% )	9.74	9.91	-1.6%	2.209	2.296
2500.011	1.634	1.634	0.000 ( +0.0% )	5.28	5.32	-0.8%	2.345	2.491
2500.012	1.517	1.517	0.000 ( +0.0% )	7.48	7.66	-2.2%	2.267	2.383
2500.1	2.126	2.126	0.000 ( +0.0% )	5.35	5.35	+0.1%	1.940	2.028
2500.2	2.237	2.237	0.000 ( +0.0% )	6.16	6.12	+0.6%	1.844	1.942
2500.21	1.125	1.125	0.000 ( +0.0% )	4.42	4.40	+0.3%	2.095	2.232
2500.211	1.479	1.479	0.000 ( +0.0% )	3.83	3.89	-1.5%	2.136	2.310
2500.3	1.995	1.995	0.000 ( +0.0% )	12.96	13.06	-0.8%	1.828	1.919
2500.31	1.201	1.201	0.000 ( +0.0% )	20.43	20.88	-2.2%	2.164	2.324
2500.311	1.579	1.579	0.000 ( +0.0% )	14.24	14.64	-2.8%	2.207	2.399
2500.4	1.995	1.995	0.000 ( +0.0% )	12.93	13.09	-1.2%	1.831	1.922

simonepigazzini · 2023-10-02T08:35:04Z

please test

cmsbuild · 2023-10-02T11:20:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ace32/34996/summary.html
COMMIT: 917feb0
CMSSW: CMSSW_13_3_X_2023-10-01-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42898/34996/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3358320
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3358289
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15925
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15925
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.469	2.469	0.000 ( +0.0% )	5.31	5.23	+1.5%	2.161	2.156
2500.001	2.611	2.611	0.000 ( +0.0% )	4.75	4.79	-0.8%	2.557	2.590
2500.002	2.522	2.522	0.000 ( +0.0% )	4.95	4.92	+0.5%	2.557	2.569
2500.01	1.264	1.264	0.000 ( +0.0% )	9.65	9.84	-1.8%	2.214	2.268
2500.011	1.634	1.634	0.000 ( +0.0% )	5.24	5.33	-1.6%	2.357	2.465
2500.012	1.517	1.517	0.000 ( +0.0% )	7.44	7.67	-3.0%	2.280	2.375
2500.1	2.126	2.126	0.000 ( +0.0% )	5.33	5.34	-0.2%	2.012	2.013
2500.2	2.237	2.237	0.000 ( +0.0% )	6.07	6.17	-1.6%	1.922	1.924
2500.21	1.125	1.125	0.000 ( +0.0% )	4.40	4.45	-0.9%	2.201	2.215
2500.211	1.479	1.479	0.000 ( +0.0% )	3.74	3.87	-3.2%	2.286	2.292
2500.3	1.995	1.995	0.000 ( +0.0% )	12.63	13.10	-3.6%	1.897	1.899
2500.31	1.201	1.201	0.000 ( +0.0% )	19.56	20.40	-4.1%	2.266	2.302
2500.311	1.579	1.579	0.000 ( +0.0% )	13.30	14.69	-9.4%	2.346	2.372
2500.4	1.995	1.995	0.000 ( +0.0% )	12.63	13.00	-2.8%	1.899	1.898

simonepigazzini · 2023-10-03T12:46:09Z

+1

@nurfikri89 please add this to #42887 if needed for the upcoming production

cmsbuild · 2023-10-03T12:46:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2023-10-04T00:38:24Z

+1

…nanoDev_jmeNanoV11 [NanoAOD, JMENano] Backport of #42728 (Updates for Nano and JMENano), #42670 (Fix typos in jetsAK4 CHS and Puppi tables) and #42898 to 13_2_X

Update list of taggers to be run and stored for AK4 Puppi & CHS jets

917feb0

cmsbuild added this to the CMSSW_13_3_X milestone Sep 27, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Sep 27, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2023

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2023

cmsbuild added tests-rejected and removed tests-started labels Sep 28, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 2, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 2, 2023

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Oct 3, 2023

nurfikri89 mentioned this pull request Oct 3, 2023

[NanoAOD, JMENano] Backport of #42728 (Updates for Nano and JMENano), #42670 (Fix typos in jetsAK4 CHS and Puppi tables) and #42898 to 13_2_X #42887

Merged

cmsbuild added orp-approved and removed orp-pending labels Oct 4, 2023

cmsbuild merged commit b642812 into cms-sw:master Oct 4, 2023
13 checks passed

cmsbuild mentioned this pull request Oct 4, 2023

Updated root to tip of branch master cms-sw/cmsdist#8734

Closed

nurfikri89 deleted the from133X_202309271100_jmenano_ak4btaggerupdates branch October 29, 2023 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JMENano] Update taggers for AK4 Puppi and CHS #42898

[JMENano] Update taggers for AK4 Puppi and CHS #42898

nurfikri89 commented Sep 27, 2023

cmsbuild commented Sep 27, 2023

cmsbuild commented Sep 27, 2023

simonepigazzini commented Sep 28, 2023

simonepigazzini commented Sep 28, 2023

cmsbuild commented Sep 28, 2023

simonepigazzini commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

simonepigazzini commented Oct 3, 2023

cmsbuild commented Oct 3, 2023

antoniovilela commented Oct 4, 2023

[JMENano] Update taggers for AK4 Puppi and CHS #42898

[JMENano] Update taggers for AK4 Puppi and CHS #42898

Conversation

nurfikri89 commented Sep 27, 2023

PR description:

PR validation:

If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 27, 2023

cmsbuild commented Sep 27, 2023

simonepigazzini commented Sep 28, 2023

simonepigazzini commented Sep 28, 2023

cmsbuild commented Sep 28, 2023

RelVals-INPUT

Comparison Summary

NANO Comparison Summary

simonepigazzini commented Oct 2, 2023

cmsbuild commented Oct 2, 2023

Comparison Summary

NANO Comparison Summary

simonepigazzini commented Oct 3, 2023

cmsbuild commented Oct 3, 2023

antoniovilela commented Oct 4, 2023