Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of SingleEleNonIso HLT path of pT threshold 115 GeV to Phase2 HLT menu #42819

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

swagata87
Copy link
Contributor

PR description:

This PR adds a new HLT path (L1-seeded single electron non-isolated path) to the Phase2 regular menu and Phase2 timing menu. Performance of this new path (efficiency, rate etc) was presented in this talk at the HLT upgrade meeting of 12 Sept 2023. This is in-line with the plans of EGamma POG as outlined in this talk (slide 17) at the 6th HLT upgrade workshop in December 2022.

PR validation:

  1. runTheMatrix.py -l 24834.911 ran successfully.
  2. cmsDriver.py Phase2 -s HLT:75e33 --processName=HLTX --conditions auto:phase2_realistic_T21 --geometry Extended2026D95 --era Phase2C17I13M9 --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 --filein=/store/relval/CMSSW_13_3_0_pre2/RelValZpToEE_m6000_14TeV/GEN-SIM-DIGI-RAW/PU_131X_mcRun4_realistic_v6_2026D98PU200-v1/2580000/015b1c6a-25be-4a3c-bca3-ae047eb03fbb.root --inputCommands='keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT' -n 10 --nThreads 1 --no_exec and then cmsRun Phase2_HLT.py ran fine, and this is part of the output:
HLT-Report   HLT #  WasRun     L1S     Pre     HLT   %L1sPre    Rate  RateHi  Errors Name
HLT-Report      36      10      10      10       6  60.00000     0.0     0.0       0 HLT_Ele32_WPTight_L1Seeded
HLT-Report      37      10      10      10       9  90.00000     0.0     0.0       0 HLT_Ele115_NonIso_L1Seeded
HLT-Report      38      10      10      10       6  60.00000     0.0     0.0       0 HLT_Ele26_WP70_L1Seeded
HLT-Report      39      10      10      10       9  90.00000     0.0     0.0       0 HLT_Photon108EB_TightID_TightIso_L1Seeded
HLT-Report      40      10      10      10       8  80.00000     0.0     0.0       0 HLT_Photon187_L1Seeded
HLT-Report      41      10      10      10       5  50.00000     0.0     0.0       0 HLT_DoubleEle25_CaloIdL_PMS2_L1Seeded
HLT-Report      42      10      10      10       3  30.00000     0.0     0.0       0 HLT_DoubleEle23_12_Iso_L1Seeded
HLT-Report      43      10      10      10       7  70.00000     0.0     0.0       0 HLT_Diphoton30_23_IsoCaloId_L1Seeded
HLT-Report      48      10      10      10      10 100.00000     0.0     0.0       0 MC_Ele5_Open_Unseeded

More detailed checks of efficiency of the new path were made in CMSSW_13_1_X by running on this dataset[*] as described in the talk.

[*] /ZprimeToEE_M-6000_TuneCP5_14TeV-pythia8/Phase2Spring23DIGIRECOMiniAODPU200_Trk1GeV_131X_mcRun4_realistic_v5-v1/GEN-SIM-DIGI-RAW-MINIAOD

Backport of this PR is not necessary.

Tagging HLT upgrade convenors (@rovere, @SohamBhattacharya), EGM-HLT convenors (@DebabrataBhowmik, @ravindkv), EGM convenors (@cms-sw/egamma-pog-l2).

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42819/36939

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato, @SohamBhattacharya, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2023

type egamma

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc24ab/34814/summary.html
COMMIT: 22f8276
CMSSW: CMSSW_13_3_X_2023-09-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42819/34814/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 33 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358022
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Sep 21, 2023

@rovere and @SohamBhattacharya let us know if you have any further comments on this PR.

@SohamBhattacharya
Copy link
Contributor

@rovere and @SohamBhattacharya let us know if you have any further comments on this PR.

Swagata informed us that she's checking the paths in 13_3 RelVals. I'd wait for her conclusion.

@SohamBhattacharya
Copy link
Contributor

Hi @mmusich , no further comments on this PR.
@swagata87 has found the efficiency of Ele115 to be a bit lower than expected in 13_3, but that seems to be because of a different issue which affects all Phase-2 electron paths, and not to do with this PR itself. That's being investigated and a fix will come later.
So this PR is fine from the pov of hlt-upgrade.

@mmusich
Copy link
Contributor

mmusich commented Sep 22, 2023

no further comments on this PR.

OK, thanks.

has found the efficiency of Ele115 to be a bit lower than expected in 13_3, but that seems to be because of a different issue which affects all Phase-2 electron paths, and not to do with this PR itself.

would be good to open a gitHub issue with the details of the problem (@swagata87).

@swagata87
Copy link
Contributor Author

GH issue is opened here: #42850

@mmusich
Copy link
Contributor

mmusich commented Sep 25, 2023

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants