Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL - Add dummy collections to ECAL GPU unpacker #42844

Merged

Conversation

thomreis
Copy link
Contributor

PR description:

Adds dummy collections to the EcalCPUDigisProducer module, which produces the ecalDigis collections in the cuda branch of the SwitchProducerCUDA.
Not having the collections produced resulted in floods of warning messages about missing EcalRawData collections in the ECAL DQM monitoring task.

It is planned that the GPU unpacker will unpack the auxiliary collections in the future, replacing the dummy collections with properly filled ones.

This PR addresses part of #42720 .

PR validation:

WF 12434.512 does not show the warning messages anymore.

@thomreis
Copy link
Contributor Author

type ecal

@thomreis
Copy link
Contributor Author

enable gpu

@cmsbuild cmsbuild added the ecal label Sep 22, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42844/36975

  • This PR adds an extra 12KB to repository

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

  • EventFilter/EcalRawToDigi (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @Martin-Grunewald, @missirol, @thomreis, @wang0jin this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 22, 2023

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Sep 22, 2023

test parameters:

  • enable = gpu
  • workflows_gpu = 141.008583, 160.03502
  • addpkg = DQM/Integration

@mmusich
Copy link
Contributor

mmusich commented Sep 22, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c343/34870/summary.html
COMMIT: 270c3ba
CMSSW: CMSSW_13_3_X_2023-09-21-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42844/34870/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358022
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 23 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 45448
  • DQMHistoTests: Total failures: 3383
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 42065
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 16 log files, 18 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e38de4 into cms-sw:master Sep 25, 2023
15 checks passed
@thomreis thomreis deleted the ecal-gpu-unpacker-missing-dummycollections branch February 2, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants