-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL - Add dummy collections to ECAL GPU unpacker #42844
ECAL - Add dummy collections to ECAL GPU unpacker #42844
Conversation
type ecal |
enable gpu |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42844/36975
|
please test |
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please abort |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c343/34870/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adds dummy collections to the
EcalCPUDigisProducer
module, which produces the ecalDigis collections in thecuda
branch of theSwitchProducerCUDA
.Not having the collections produced resulted in floods of warning messages about missing EcalRawData collections in the ECAL DQM monitoring task.
It is planned that the GPU unpacker will unpack the auxiliary collections in the future, replacing the dummy collections with properly filled ones.
This PR addresses part of #42720 .
PR validation:
WF 12434.512 does not show the warning messages anymore.