Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily restore sector and endcap accessors to RegionalMuonShower #36435

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Dec 9, 2021

PR description:

This adds back the sector and endcap accessors temporarily to fix #36433.

PR validation:

Committed without validation as it's required urgently.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36435/27265

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

  • DataFormats/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@rovere, @thomreis this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@VinInn
Copy link
Contributor

VinInn commented Dec 9, 2021

@cmsbuild , please test

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

Thank you @dinyar !
An additional (non urgent, i.e. not here!) fix can be to revert to the usage of those two methods in DQM/L1TMonitor/src/L1TStage2Shower.cc

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

type bug fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b3843/21127/summary.html
COMMIT: 8310ab0
CMSSW: CMSSW_12_3_X_2021-12-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36435/21127/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b3843/21127/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b3843/21127/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250704
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250682
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

+1

  • Test succeed: let merge, otherwise next IB won't even compile
  • @cms-sw/l1-l2 FYI

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master (next IB) is broken (two inconsistent PR were merged independently)
4 participants