-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct accessors for RegionalMuonShower data type #36455
Use correct accessors for RegionalMuonShower data type #36455
Conversation
…onShower" This reverts commit 8310ab0.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36455/27301
|
A new Pull Request was created by @dinyar (Dinyar Rabady) for master. It involves the following packages:
@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-809883/21184/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
This is a cleanup PR after #36435 was used to fix #36433. Here I remove the (re)added accessors and modify both the DQM and L1TNtuple code that still used them. There should be no functional difference.
PR validation:
Ran
scram build code-checks && scram build code-format
, but skippedrunTheMatrix.py -l limited -i all --ibeos
as the code change is minor.