Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master (next IB) is broken (two inconsistent PR were merged independently) #36433

Closed
VinInn opened this issue Dec 9, 2021 · 3 comments · Fixed by #36435 or #36455
Closed

Master (next IB) is broken (two inconsistent PR were merged independently) #36433

VinInn opened this issue Dec 9, 2021 · 3 comments · Fixed by #36435 or #36455

Comments

@VinInn
Copy link
Contributor

VinInn commented Dec 9, 2021

Somehow the master is broken due to DQM/L1TMonitor #36396 which, in its own PR was fine. BUT not with #35627 .
Please revert one of the two.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

A new Issue was created by @VinInn Vincenzo Innocente.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@VinInn VinInn changed the title Master (next IB) is broken (two inconsistent PR where merged independently) Master (next IB) is broken (two inconsistent PR were merged independently) Dec 9, 2021
@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

Fixed by #36435 by @dinyar

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

The fix restores the accessors sector() and endcap() of RegionalMuonShower

For the record, the two accessors were used in

If those two methods want to be removed, those four lines must be adapted accordingly.

If those two methods want to be kept, as in #36435, then one should revert to use them in DQM/L1TMonitor/src/L1TStage2Shower.cc , see https://github.com/cms-sw/cmssw/pull/35627/files#diff-36be1ac5253fe760c0624c85ca8ff03e64fd0c204314226186b2ce4d692ea13bR169 and another line farther below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants