Run3-gex101 Add the geometry version with the added GE21 demonstrator #36338

bsunanda · 2021-12-02T15:48:57Z

PR description:

Add the geometry version with the added GE21 demonstrator. All the files referred in this PR refer to Run3 scenario with the demonstrator GE21 chamber. The production cut file used here is preliminary and will be decided only after discussion in the SIM meeting

PR validation:

Use an overlap tool in Geometry/MuonCommonData/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-12-02T15:59:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36338/27089

This PR adds an extra 32KB to repository

cmsbuild · 2021-12-02T15:59:48Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/GEMGeometryBuilder (geometry, upgrade)
Geometry/MuonCommonData (geometry)
Geometry/MuonSimData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @watson-ij, @jshlee, @dildick, @ptcox, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-12-02T17:46:38Z

@cmsbuild Please test

cmsbuild · 2021-12-02T20:43:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86692e/20946/summary.html
COMMIT: bc27b17
CMSSW: CMSSW_12_2_X_2021-12-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36338/20946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 41
DQMHistoTests: Total histograms compared: 3041955
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3041933
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
Checked 175 log files, 37 edm output root files, 41 DQM output files
TriggerResults: no differences found

watson-ij · 2021-12-03T15:43:22Z

Geometry/MuonSimData/data/muonProdCuts/2021/v3/muonProdCuts.xml

+   <PartSelector path="//MB.*PhiGas"/>
+   <PartSelector path="//MB.*ZGas"/>
+   <PartSelector path="//ME.*ActiveGasVol"/>
+   <PartSelector path="//GHA.*"/>


This is the GEM sensitive volume right? I think we want to remove this, and keep consistent with the other geometries

GHA* corresponds to the sensitive part and this is consistent with other product file - mainly the ones corrected fro Phase2

Yes, but this is for CSC, and as Tim said today, the CSC digitizer is internally doing a microsimulation from the simhits, whereas in GEM we have a simple efficiency based digitizer that has been adapted to the existing simulation, which is using the MuonChamber cuts. So, I think it would be better to be consistent with the previous xmls. We are also planning to update the digitizer later on, maybe @jshlee could comment more on that.

ptcox · 2021-12-03T19:37:07Z

Hi Ian, Sunanda, I'm sorry - I am not exactly following what's been changed/being reverted but please don't change CSC without some thought. I'm sure you won't :) (Although we do a micro-simulation across the CSC gas gap, corresponding to a simhit, we still want GEANT to get the best possible estimate of the energy loss. Although that is not used at present - we get our own from the micro-simulation - in the future I think it likely we will want to, somehow, use the GEANT energy loss, because I don't see any other way of ensuring the digitization of energy loss from non-muon and exotic charged particles gets done correctly.). Regards, Tim

________________________________ From: Ian J. Watson ***@***.*** Sent: 03 December 2021 20:19 To: cms-sw/cmssw Cc: Tim Cox; Mention Subject: Re: [cms-sw/cmssw] Run3-gex101 Add the geometry version with the added GE21 demonstrator (PR #36338) @watson-ij commented on this pull request.

________________________________ In Geometry/MuonSimData/data/muonProdCuts/2021/v3/muonProdCuts.xml<#36338 (comment)>:

+ <PartSelector path="//MB.*N"/>

+ <PartSelector path="//MB.*P"/> + <PartSelector path="//ME.*Space"/> + <PartSelector path="//RR.*"/> + <PartSelector path="//GE.*"/> + <Parameter name="CMSCutsRegion" value="MuonChamber" eval="false"/> + <Parameter name="ProdCutsForGamma" value="1.0*mm"/> + <Parameter name="ProdCutsForElectrons" value="0.002*mm"/> + <Parameter name="ProdCutsForPositrons" value="0.002*mm"/> + </SpecPar> + <SpecPar name="MuonSensitive_DT-CSC"> +  + <PartSelector path="//MB.*PhiGas"/> + <PartSelector path="//MB.*ZGas"/> + <PartSelector path="//ME.*ActiveGasVol"/> + <PartSelector path="//GHA.*"/> Yes, but this is for CSC, and as Tim said today, the CSC digitizer is internally doing a microsimulation from the simhits, whereas in GEM we have a simple efficiency based digitizer that has been adapted to the existing simulation, which is using the MuonChamber cuts. So, I think it would be better to be consistent with the previous xmls. We are also planning to update the digitizer later on, maybe @jshlee<https://github.com/jshlee> could comment more on that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#36338 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGYLHXXYLKGZC47RSSFJFDUPEJ5NANCNFSM5JHOTSYA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

watson-ij · 2021-12-03T19:53:08Z

Hi Ian, Sunanda, I'm sorry - I am not exactly following what's been changed/being reverted but please don't change CSC without some thought. I'm sure you won't :) (Although we do a micro-simulation across the CSC gas gap, corresponding to a simhit, we still want GEANT to get the best possible estimate of the energy loss. Although that is not used at present - we get our own from the micro-simulation - in the future I think it likely we will want to, somehow, use the GEANT energy loss, because I don't see any other way of ensuring the digitization of energy loss from non-muon and exotic charged particles gets done correctly.). Regards, Tim
________________________________ From: Ian J. Watson @.*** Sent: 03 December 2021 20:19 To: cms-sw/cmssw Cc: Tim Cox; Mention Subject: Re: [cms-sw/cmssw] Run3-gex101 Add the geometry version with the added GE21 demonstrator (PR #36338) @watson-ij commented on this pull request.
________________________________ In Geometry/MuonSimData/data/muonProdCuts/2021/v3/muonProdCuts.xml<#36338 (comment)>:

+ + + + + + + + + + + + + + Yes, but this is for CSC, and as Tim said today, the CSC digitizer is internally doing a microsimulation from the simhits, whereas in GEM we have a simple efficiency based digitizer that has been adapted to the existing simulation, which is using the MuonChamber cuts. So, I think it would be better to be consistent with the previous xmls. We are also planning to update the digitizer later on, maybe @jshlee https://github.com/jshlee could comment more on that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#36338 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGYLHXXYLKGZC47RSSFJFDUPEJ5NANCNFSM5JHOTSYA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi Tim,

Indeed, this isn't about changing the CSC, but about whether the GEM sensitive volumes should follow exactly what CSC is doing or not. For this new file, which would include the GE2/1 demonstrator we just installed, the only relevant difference for this discussion should be the GHA.* (gem sensitive volumes) being added to the MuonSensitive_CSC-DT, which is something we tried when trying to find the source of the ME0 vs GE0 simhit rate differences, though ultimately we found the ME0 wasn't included in any of the prod cuts and was just taking the default values.

Cheers,
Ian

cvuosalo · 2021-12-03T20:53:44Z

Geometry/MuonSimData/data/muonProdCuts/2021/v3/muonProdCuts.xml

+   <!--    <PartSelector path="//REG.*"/>  -->
+   <!--    <PartSelector path="//REH.*"/>  -->
+   <Parameter name="CMSCutsRegion" value="MuonSensitive_RPC" eval="false"/>
+   <Parameter name="ProdCutsForGamma" value="1.0*cm"/>


The original value for this line was 8.5 m, and you are changing it to 1.0 cm. How is this change related to the demo GEM chamber? What effect will it have to make such a large change in value?

This is done in consultation with Vladimir - 8.5m means no production of photons at all which is not a reliable cut off for Geant4 (might be OK for Geant3).

watson-ij · 2021-12-04T02:15:43Z

Ah, I missed that the values are also changed. Ignore my comment, sorry for the noise.

watson-ij · 2021-12-07T06:25:45Z

I'm going through the muonProdCuts.xml files again a bit more slowly this time, to try to sort through this, since I think I was confusing myself with the various files. We have:

M9 [1] (and earlier M4-8) uses 'Geometry/MuonSimData/data/PhaseII/muonProdCuts.xml', which doesn't include any GHA.* cuts, but does have GE.* in the MuonChamber specpar [2]
M10 [3] uses 'Geometry/MuonSimData/data/muonProdCuts/2026/v2/muonProdCuts.xml', which includes the GHA.*, and changes the prodcuts to smaller values in both MuonSenstive DT-CSC and RPC [4]
The current 2021 [5] uses 'Geometry/MuonSimData/data/muonProdCuts/2021/v1/muonProdCuts.xml' [6], which has the GE.* in the muonchamber, but no GHA.* and has the larger values in MuonSensitive

So, the version here is basically the same as the M10 file, in which case @cvuosalo your comment would also apply to M10? Or these values should be updated for 2026, but not 2021?

[1]

cmssw/Configuration/Geometry/python/dict2026Geometry.py

Line 1257 in ad04da7

'Geometry/MuonSimData/data/PhaseII/muonProdCuts.xml',

[2] https://github.com/cms-sw/cmssw/blob/master/Geometry/MuonSimData/data/PhaseII/muonProdCuts.xml
[3]

cmssw/Configuration/Geometry/python/dict2026Geometry.py

Line 1304 in ad04da7

'Geometry/MuonSimData/data/muonProdCuts/2026/v2/muonProdCuts.xml',

[4] https://github.com/cms-sw/cmssw/blob/master/Geometry/MuonSimData/data/muonProdCuts/2026/v2/muonProdCuts.xml
[5]

cmssw/Geometry/CMSCommonData/python/cmsExtendedGeometry2021XML_cfi.py

Line 374 in ad04da7

'Geometry/MuonSimData/data/muonProdCuts/2021/v1/muonProdCuts.xml',

[6] https://github.com/cms-sw/cmssw/blob/master/Geometry/MuonSimData/data/muonProdCuts/2021/v1/muonProdCuts.xml

bsunanda · 2021-12-07T13:36:24Z

GHA is present for the 2021 version - the only difference between the one in M10 and one here is removal of 2 regions for RPC which are present in Phase2 and not in Run3

bsunanda · 2021-12-07T13:37:44Z

@watson-ij Please check now

bsunanda · 2021-12-07T13:37:58Z

@cmsbuild Please test

srimanob · 2021-12-09T01:29:14Z

+Upgrade

From the upgrade side, new xml(s) are added in Geometry/GEMGeometryBuilder.

cmsbuild · 2021-12-09T01:29:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

srimanob · 2021-12-09T01:30:35Z

hold

As mentioned in the PR description, the production cut file in the PR will be discussed in the next SIM meeting (17 Dec). If I understand correctly, we can hold this PR until then.

cmsbuild · 2021-12-09T01:30:58Z

Pull request has been put on hold by @srimanob
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

civanch · 2021-12-09T07:24:41Z

@srimanob, we need to discuss at SIM meeting if we have to do something on top of this PR. This PR itself is fine. Please, unhold.

civanch · 2021-12-09T13:06:22Z

@perrotta, @qliphy, @srimanob, please, unhold and merge this PR, because we need continue developments, this PR does not bring any damage. Extensive discussion on this PR is useful and does not mean that there is a problem.

srimanob · 2021-12-09T13:19:51Z

unhold

cmsbuild · 2021-12-09T13:20:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

srimanob · 2021-12-09T13:21:02Z

@civanch I've unholded the PR, and I signed it before for the Upgrade side. This PR is ready to go if no more concerns. Thanks for clarification.

perrotta · 2021-12-09T13:58:00Z

+1

Add the geometry version with the added GE21 demonstrator

bc27b17

cmsbuild added this to the CMSSW_12_2_X milestone Dec 2, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Dec 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 2, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 2, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 2, 2021

watson-ij reviewed Dec 3, 2021

View reviewed changes

cvuosalo reviewed Dec 3, 2021

View reviewed changes

smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021

Get 1 rather than 9 chambers

0b54fed

cmsbuild added geometry-approved and removed geometry-pending labels Dec 8, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Dec 9, 2021

cmsbuild added hold pending-signatures and removed fully-signed labels Dec 9, 2021

cmsbuild added fully-signed and removed pending-signatures hold labels Dec 9, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 9, 2021

cmsbuild merged commit 9d1098c into cms-sw:master Dec 9, 2021

This was referenced Dec 9, 2021

Temporarily restore sector and endcap accessors to RegionalMuonShower #36435

Merged

[Do not merge] testing bot #36437

Closed

[12.3.X] Move to root 6.24 cms-sw/cmsdist#7500

Merged

[ROOT624] Testing root 62.4 for gcc10 cms-sw/cmsdist#7505

Closed

perrotta mentioned this pull request Jan 23, 2022

Run3-gex108XA Backport al Geometry related files - xml and code for the corrected Run3 geometry #36740

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex101 Add the geometry version with the added GE21 demonstrator #36338

Run3-gex101 Add the geometry version with the added GE21 demonstrator #36338

bsunanda commented Dec 2, 2021 •

edited

Loading

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

bsunanda commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

watson-ij Dec 3, 2021

bsunanda Dec 3, 2021

watson-ij Dec 3, 2021

ptcox commented Dec 3, 2021 via email

watson-ij commented Dec 3, 2021

cvuosalo Dec 3, 2021

bsunanda Dec 7, 2021

watson-ij commented Dec 4, 2021

watson-ij commented Dec 7, 2021

bsunanda commented Dec 7, 2021

bsunanda commented Dec 7, 2021

bsunanda commented Dec 7, 2021

srimanob commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

srimanob commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

civanch commented Dec 9, 2021 •

edited

Loading

civanch commented Dec 9, 2021

srimanob commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

srimanob commented Dec 9, 2021

perrotta commented Dec 9, 2021

Run3-gex101 Add the geometry version with the added GE21 demonstrator #36338

Run3-gex101 Add the geometry version with the added GE21 demonstrator #36338

Conversation

bsunanda commented Dec 2, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

bsunanda commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

Comparison Summary

watson-ij Dec 3, 2021

Choose a reason for hiding this comment

bsunanda Dec 3, 2021

Choose a reason for hiding this comment

watson-ij Dec 3, 2021

Choose a reason for hiding this comment

ptcox commented Dec 3, 2021 via email

watson-ij commented Dec 3, 2021

cvuosalo Dec 3, 2021

Choose a reason for hiding this comment

bsunanda Dec 7, 2021

Choose a reason for hiding this comment

watson-ij commented Dec 4, 2021

watson-ij commented Dec 7, 2021

bsunanda commented Dec 7, 2021

bsunanda commented Dec 7, 2021

bsunanda commented Dec 7, 2021

srimanob commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

srimanob commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

civanch commented Dec 9, 2021 • edited Loading

civanch commented Dec 9, 2021

srimanob commented Dec 9, 2021

cmsbuild commented Dec 9, 2021

srimanob commented Dec 9, 2021

perrotta commented Dec 9, 2021

bsunanda commented Dec 2, 2021 •

edited

Loading

civanch commented Dec 9, 2021 •

edited

Loading