-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASAN] fix unit tests by setting NO_TEST_PREFIX flag for ASAN IB #36365
Conversation
please test for CMSSW_12_2_ASAN_X |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36365/27130
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@ggovi, @malbouis, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test test_CondToolsSiPhase2Tracker had ERRORS Comparison SummarySummary:
|
please test for CMSSW_12_2_ASAN_X |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test testGetPayloadData had ERRORS ---> test testWriteReadAlCaRecoTriggerBits had ERRORS ---> test SiStripDCS_O2O_test had ERRORS ---> test test_CondToolsSiPhase2Tracker had ERRORS and more ... Comparison SummarySummary:
|
I see "==21987==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD." |
@tvami I think this is an expected message |
Ah ok, so we are good then, right? |
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
Attempt to fix failing unit tests in ASAN builds, similar to #36249 .