Phase2 tracker cabling map: add IT cabling map

[adewit]

PR description:

This adds the IT cabling map for the Phase 2 tracker to the cabling map producer. Requires the updated input data here: cms-data/CondTools-SiPhase2Tracker#3

With this change we also read the lpGBT IDs from the external file for the OT, rather than automatically assigning them as was done before.

PR validation:

Checked that the new map does not change the detID<>DTC links for OT compared with the version currently in the GTs (TrackerDetToDTCELinkCablingMap__OT616_200_IT613__T14__OTOnly), and that the IT information is also picked up correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36333/27078

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @adewit for master.

It involves the following packages:

• CondTools/SiPhase2Tracker (upgrade, alca)

@malbouis, @yuanchao, @cmsbuild, @AdrianoDee, @srimanob, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test with cms-data/CondTools-SiPhase2Tracker#3

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e42ec/20931/summary.html
COMMIT: 9c29b74
CMSSW: CMSSW_12_2_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36333/20931/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 17245 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 23355
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3018578
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[tvami]

Naively I would have expected to see changes in Phase-2 only, but 2017 and 2018 wf-s show big differences (in tracking vertexing, b-tagging). Is this expected? @adewit

[mmusich]

Naively I would have expected to see changes in Phase-2 only, but 2017 and 2018 wf-s show big differences (in tracking vertexing, b-tagging). Is this expected?

No changes are expected anywhere. Clearly something got screwed with the comparison.

[tvami]

@cmsbuild, please test with cms-data/CondTools-SiPhase2Tracker#3

[tvami]

@cmsbuild, please test with cms-data/CondTools-SiPhase2Tracker#3

I hope this will pick up the 1100 IB

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e42ec/20945/summary.html
COMMIT: 9c29b74
CMSSW: CMSSW_12_2_X_2021-12-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36333/20945/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[tvami]

Now this looks good!

[tvami]

+alca

• unit testing creating the new cabling map DB object runs fine https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e42ec/20945/unitTests/src/CondTools/SiPhase2Tracker/test/test_CondToolsSiPhase2Tracker/testing.log

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1