DAQ - adding DCS validity bitfield for high voltage in FED 1022

[smorovic]

DCS HV validity field added to the DCSRecord for discerning if information was available to the data reader.

PR validation:

Added a unittest with the FED dump containing the new format. Test was set to require status seen in the application creating the payload, and it passes.
The whole chain (input source, unpacker) was also tested on the raw file from a cosmic run (with DCS v1 only).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36294/27005

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

• DataFormats/OnlineMetaData (daq, reconstruction)
• EventFilter/OnlineMetaDataRawToDigi (daq, reconstruction)

@jpata, @cmsbuild, @emeschi, @smorovic, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smorovic]

@cmsbuild please test

[smorovic]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36294/27017

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #36294 was updated. @jpata, @emeschi, @smorovic, @slava77 can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f683e/20867/summary.html
COMMIT: 00df237
CMSSW: CMSSW_12_2_X_2021-11-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36294/20867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3042214
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3042192
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[smorovic]

+1

[jpata]

+reconstruction

• DAQ only, no reco-relevant code changes (the code was reviewed by visual inspection)
• no reco changes expected/observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@smorovic DataFormats/OnlineMetaData/test/dump_run000001_event1350583585_fed1022.txt seems like an output file from some test that sneaked in the PR by mistake: if so, please remove

[smorovic]

@perotta, It is needed by the unit test:
https://github.com/cms-sw/cmssw/pull/36294/files#diff-7aa942529fe0564733b0e59e94a6d58177fe3112321c0647bc2c74ba512eba97R115

Similar to another already present file (dump of raw payload of the FED):
https://github.com/cms-sw/cmssw/blob/master/DataFormats/OnlineMetaData/test/dump_run000001_event00013761_fed1022.txt

[perrotta]

+1