-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASAN] fix unit tests by setting NO_TEST_PREFIX flag for ASAN IB #36249
Conversation
FYI @iarspider |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36249/26902
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please test with cms-sw/cmsdist#7469 for CMSSW_12_2_ASAN_X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f066d8/20762/summary.html Comparison SummarySummary:
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-dt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-dt4ml_dqm_sourceclient had ERRORS ---> test TestDQMServicesDemo had ERRORS ---> test TestDQMOnlineClient-pixellumi_dqm_sourceclient had ERRORS and more ... Comparison SummarySummary:
|
@smuzaffar I am able to reproduce the errors but, for the TestDQMOnlineClient-* I don't understand what has changed in ASAN to give those errors now since those modules have not changed since more than a year. I will research the DT related ones. For the pixelLumi one, I let @sroychow to comment on the crash produced in: PixelLumiDQM::calculateBunchMask For the TestDQMServicesDemo, this is being discussed on: #36063 |
no idea @jfernan2 , there were many unit tests which were failing for ASAN IBs and few of those errors were hidden due to |
OK, I'll do as you suggest |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Unit tests for
DQM/Integration
hang [a] for ASAN IBs as scram setsLD_PRELOAD=libasan.so
for each unit tests. Running tests without LD_PRELOAD works. cms-sw/cmsdist#7469 Allows tests to instruct scram to not add test prefix. This should fix the unit tests for ASAN IBs.[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_2_ASAN_X_2021-11-24-2300/unitTestLogs/DQM/Integration#/