-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bianca pinolini ecal reco phase2 commit unimib #34212
Closed
BiancaPinolini
wants to merge
48
commits into
cms-sw:master
from
UniMiBAnalyses:BiancaPinolini-ecal-reco-phase2-commit-unimib
Closed
Bianca pinolini ecal reco phase2 commit unimib #34212
BiancaPinolini
wants to merge
48
commits into
cms-sw:master
from
UniMiBAnalyses:BiancaPinolini-ecal-reco-phase2-commit-unimib
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[11.2.X] add RecoLocalTracker_cff to TrackRefitters_cff
…icit deleted def-constructor backport of cms-sw#32307
… it runs reliably)
Run3-gex39x Correct zdcmaterials.xml and backport from PR#32299
[11.2.X][clang] Initialize data member to fix clang errors
[11.2.X]Remove 11624.911, cms-sw#2021 DD4hep from short matrix (until it runs reliably)
…riterForBU_fillDescriptions Implement the fillDescriptions method for RawStreamFileWriterForBU (11.2.x)
Remove temporarily ctppsProtons from recoCTPPSTask (Run-3 only, 11_2_X backport)
…112X Set default value for jets w/o SV info in HI CSV tagger (112X)
Add FakeHLT steps to Patatrack WFs.
HcalDQM: add dqmSaverPB to hcalcalib client
…OD_112X Use cleaned PF candidates in UE subtraction in HI miniAOD (112X)
…ort-v1 [DD4hep] backport of 32339 and 32371 to assure thread-safe dd4hep workflow
…IsolationProducerFix Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates (backport to 11_2_X)
…pre11 HLT menu migration to 11_2_0_pre11 template
…11_2_X New JEC for 2018 HI re-miniAOD [11_2_X]
Fix reflection integrity
This was referenced Jul 13, 2021
cmsbuild
added
code-checks-pending
hlt-pending
reconstruction-pending
and removed
code-checks-rejected
hlt-rejected
reconstruction-rejected
labels
Jul 15, 2021
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34212/23988 ERROR: Build errors found during clang-tidy run.
|
-1 looks broken |
Hi @BiancaPinolini I think you can close this PR in favour of #34505 |
This was referenced Jul 16, 2021
-1 |
-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The necessary files to implement the amplitude reconstruction for Ecal-Phase2 through the weights method has been added.