Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bianca pinolini ecal reco phase2 commit unimib #34212

Conversation

BiancaPinolini
Copy link
Contributor

The necessary files to implement the amplitude reconstruction for Ecal-Phase2 through the weights method has been added.

Sunanda and others added 30 commits November 27, 2020 16:02
[11.2.X] add RecoLocalTracker_cff to TrackRefitters_cff
Run3-gex39x Correct zdcmaterials.xml and backport from PR#32299
[11.2.X][clang] Initialize data member to fix clang errors
[11.2.X]Remove 11624.911, cms-sw#2021 DD4hep from short matrix (until it runs reliably)
…riterForBU_fillDescriptions

Implement the fillDescriptions method for RawStreamFileWriterForBU (11.2.x)
Remove temporarily ctppsProtons from recoCTPPSTask (Run-3 only, 11_2_X backport)
…112X

Set default value for jets w/o SV info in HI CSV tagger (112X)
Add FakeHLT steps to Patatrack WFs.
HcalDQM: add dqmSaverPB to hcalcalib client
…OD_112X

Use cleaned PF candidates in UE subtraction in HI miniAOD (112X)
…ort-v1

[DD4hep] backport of 32339 and 32371 to assure thread-safe dd4hep workflow
…IsolationProducerFix

Adopt ChargedHadronPFTrackIsolationProducer for PFTICL candidates (backport to 11_2_X)
…pre11

HLT menu migration to 11_2_0_pre11 template
…11_2_X

New JEC for 2018 HI re-miniAOD [11_2_X]
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34212/23988

ERROR: Build errors found during clang-tidy run.

--
DetectorDescription/DDCMS/plugins/test/DDTestSpecParsFilter.cc:75:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
FWCore/Framework/interface/EventSetupImpl.h:86:5: warning: deleted member function should be public [modernize-use-equals-delete]
--
Geometry/TrackerNumberingBuilder/src/GeometricDet.cc:114:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 1921 warnings (1920 in non-user code, 1 with check filters).
--
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:18:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:133:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
SimG4Core/Geometry/src/DDG4ProductionCuts.cc:272:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 2306 warnings (2305 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@slava77
Copy link
Contributor

slava77 commented Jul 16, 2021

-1

looks broken

@thomreis
Copy link
Contributor

Hi @BiancaPinolini I think you can close this PR in favour of #34505

@Martin-Grunewald
Copy link
Contributor

-1
to remove from HLT queue - please rebase properly!

@tvami
Copy link
Contributor

tvami commented Jul 21, 2021

-1
to remove from AlCa queue, the PR is anyway to be closed since an alternative PR exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment