Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JEC for 2018 HI re-miniAOD [11_2_X] #32453

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of PR #32375. The content of this PR is identical to that of #32375, though I squashed the commits to remove a commit with an incorrect GT.

This PR updates the HI JEC for the re-miniAOD of the 2018 HI run. The 2018 HI MC as well as the 2018 HI IOVs of the prompt-like data JEC tags are updated. The GT diffs are as follows:

Prompt-like data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_PromptLike_HI_v3/112X_dataRun2_PromptLike_HI_v5

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HI_v5/112X_upgrade2018_realistic_HI_v6

PR validation:

See the HN thread for details. In addition, a technical test was performed: runTheMatrix.py -l limited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of PR #32375. It it being backported because it intended for use in a HI re-miniAOD in 11_2_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for CMSSW_11_2_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5a867/11546/summary.html
CMSSW: CMSSW_11_2_X_2020-12-11-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 242
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5dccc23 into cms-sw:CMSSW_11_2_X Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants