-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Enable Run 3 DD4hep DB workflow with correct GT for PR & IB tests #34526
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34526/24039
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages:
@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf870/16934/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade The new workflow is running fine. I think if it enters IB and can run smoothly, it should be good to be relvals. I understand that GT that PdmV should use for relvals is |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Since Run 3 DD4hep workflows reading geometry from the DB are now functional, such a workflow can be added to the PR and IB tests.
11634.912 (ttbar) had been previously defined but left disabled. This PR enables this workflow for PR/IB tests. The GT for this workflow is also corrected.
PR validation:
The workflow runs successfully with:
runTheMatrix.py -l 11634.912 --ibeos