[clang] Initialize data member to fix clang errors about explicit deleted def-constructor

[smuzaffar]

Since we moved to GCC9, the CLANG IBs (for 11.2.X and 11.3.X ) had compilation error [a]. This PR proposes to explicitly initialize the data member.

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_11_3_CLANG_X_2020-11-26-2300/PhysicsTools/PatAlgos

  PhysicsTools/PatAlgos/plugins/PATTriggerProducer.cc:45:21: error: call to implicitly-deleted default constructor of 'pat::PATTriggerProducer::ModuleLabelToPathAndFlags'
 PATTriggerProducer::PATTriggerProducer(const ParameterSet& iConfig)
                    ^
PhysicsTools/PatAlgos/plugins/PATTriggerProducer.h:145:39: note: default constructor of 'ModuleLabelToPathAndFlags' is implicitly deleted because field 'empty_' of const-qualified type 'const std::vector<PathAndFlags>' would not be initialized
      const std::vector<PathAndFlags> empty_;

[smuzaffar]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32307/20127

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32307/20127/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32307/20127/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32307/20128

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-26-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11092/console Started: 2020/11/27 09:25

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @smoortga, @schoef, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 78e1c57

CMSSW: CMSSW_11_3_X_2020-11-26-2300
SCRAM_ARCH: slc7_amd64_gcc900
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75aae0/11092/summary.html

I found follow errors while testing this PR

Failed tests: HeaderConsistency RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
11624.911 step1

runTheMatrix-results/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[smuzaffar]

relval failure has nothing to do with this PR. This PR should fix the clang IBs and clang errors for PR tests (and it did , see https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75aae0/11092/buildClang.log ). Can we get this in IBs so that clang errors for PR tests go away?

What to do with this 11624.911 workflow? It is failing for all PRs tests and due to this the comparison job is not running (as we do not run comparison job is relvals fail)

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #31220,cms-data/RecoEgamma-ElectronIdentification#15,#32313
Test Parameters:

• MATRIX_EXTRAS = 136.898,1304.182
• CMSSW_11_3_X_2020-11-27-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11124/console Started: 2020/11/28 02:58

[cmsbuild]

+1
Tested at: 6f84ccd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-221782/11124/summary.html
CMSSW: CMSSW_11_3_X_2020-11-27-2300
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[silviodonato]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-221782/11124/summary.html

There are some workflows for which there are errors in the baseline:
11624.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-221782/1304.182_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18bParking+MINIAODMCUP18bParking
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-221782/136.898_RunParkingBPH2018B+RunParkingBPH2018B+HLTDR2_2018+RECODR2_2018reHLT_skimParkingBPH_Offline+HARVEST2018

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529564
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.