L1 phase 2: produce CaloJet/Tau #33612

cecilecaillol · 2021-05-03T16:37:09Z

PR description:

Updated Phase2 L1 CaloJet/Tau code from CMSSW_10_5_0_pre1 release to new data formats in more recent release and added minimum code necessary to produce CaloJets/Taus (L1Trigger/L1CaloTrigger/).

PR validation:

Ran python test script to test full CaloJet sequence (L1Trigger/L1CaloTrigger/python/L1CaloJets_cff.py) using latest VBFHiggsTauTau samples. Also successfully produced efficiency plots for CaloTaus.

Rebasing from cms-l1t-offline#861

if this PR is a backport please specify the original PR and why you need to backport that PR:

Rebasing from cms-l1t-offline#861

cmsbuild · 2021-05-03T17:18:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22446

This PR adds an extra 56KB to repository
Found files with invalid states:
- L1Trigger/TrackFindingTracklet/python/L1TrackletTracks_cff.py:
  - Added: 2b5f12a
  - Deleted: 5e7f14c

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22446/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22446/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22446/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22446/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

Validation/Geometry apply futurize stage1; use six.iteritems; use python3 for matplotlib

…ge-topic

cmsbuild · 2021-05-04T07:48:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22464

This PR adds an extra 68KB to repository
Found files with invalid states:
- L1Trigger/TrackFindingTracklet/python/L1TrackletTracks_cff.py:
  - Added: 2b5f12a
  - Deleted: 5e7f14c

cmsbuild · 2021-05-04T07:48:43Z

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

DataFormats/L1TCalorimeterPhase2
L1Trigger/L1CaloTrigger
L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @skinnari, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2021-05-04T07:49:02Z

please test

minor change

(cherry picked from commit 4e4619f)

(cherry picked from commit 3a9823f)

(cherry picked from commit 6d65423)

(cherry picked from commit 9d45304)

(cherry picked from commit 95c3e28)

(cherry picked from commit f9e0c91)

MTD geometry and reconstruction: store ETL layout logic into MTDTopology, use for ETL layers navigation in reconstruction

…ge-topic

cecilecaillol · 2021-05-17T10:43:39Z

I updated to a newer CMSSW release and included many irrelevant PRs. I will reopen a clean PR with the Calo jets/taus.

cmsbuild · 2021-05-17T10:43:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33612/22695

This PR adds an extra 28KB to repository
Found files with invalid states:
- L1Trigger/Phase2L1ParticleFlow/python/L1METPFProducer_cfi.py:
  - Added: 5c055aa
  - Deleted: a3612b9
- L1Trigger/TrackFindingTracklet/test/L1TrackObjectNtupleMaker.cc:
  - Added: ba6c6b9
  - Modified: 987f795
  - Deleted: 5d86491
- L1Trigger/Phase2L1ParticleFlow/plugins/L1MetPfProducer.cc:
  - Added: 4815057
  - Modified: eaeba68, 30fa8fb, 03a332b, 9dcba0e, 5ba474f
  - Deleted: 5c055aa
- L1Trigger/Phase2L1ParticleFlow/python/L1MetPfProducer_cfi.py:
  - Added: 4815057
  - Modified: eaeba68, 30fa8fb, 03a332b, b83fdbb, 9dcba0e, bc6ed5f
  - Deleted: 5c055aa
- Validation/MtdValidation/macro/makeTimeResPlots.C:
  - Added: defee1c
  - Deleted: d3b4d12
- L1Trigger/Phase2L1ParticleFlow/plugins/L1MetPfProducerHLS.cc:
  - Added: 4815057
  - Modified: eaeba68
  - Deleted: 30fa8fb
- L1Trigger/TrackFindingTracklet/test/L1TrackObjectNtupleMaker_cfg.py:
  - Added: ba6c6b9
  - Deleted: 5d86491
- L1Trigger/Phase2L1ParticleFlow/plugins/L1MetPfProducerNewTypes.cc:
  - Added: b83fdbb
  - Deleted: 9dcba0e
- L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.h:
  - Added: ba6c6b9
  - Modified: 976a1ae, 987f795
  - Deleted: 4e61998
- L1Trigger/Phase2L1ParticleFlow/plugins/L1MetPfProducerTDR.cc:
  - Added: 9dcba0e
  - Deleted: bc6ed5f
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add customisation to make sure that upgrade WFs will cross LS in the short matrix #32957, Make run-dependent MC configurable with cmsDriver options #33555
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548, Add run3 tracking low pu era #33532
- File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): CondDB frontierKey update #33643
- File DQM/Integration/python/clients/beamfake_dqm_sourceclient-live_cfg.py modified in PR(s): CondDB frontierKey update #33643
- File DQM/Integration/python/clients/beamhlt_dqm_sourceclient-live_cfg.py modified in PR(s): CondDB frontierKey update #33643
- File DQM/Integration/python/clients/beamhltfake_dqm_sourceclient-live_cfg.py modified in PR(s): CondDB frontierKey update #33643
- File DQM/L1TMonitor/python/L1TStage2Emulator_cff.py modified in PR(s): Fix valEmtfStage2Digis for unpacked GEM clusters in GEN-SIM-RAW #33694
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File DataFormats/L1TParticleFlow/src/classes_def.xml modified in PR(s): L1T phase-2 Update old PF emulators with E/gamma integration, and add new emulators (12_0_X version) #33605
- File DataFormats/L1Trigger/src/classes_def.xml modified in PR(s): L1T phase-2: Add the Phase2 L1T VertexFinder #33609
- File GeneratorInterface/LHEInterface/plugins/ExternalLHEProducer.cc modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Add argument postGenerationCommand to ExternalLHEProducer and provide mergeLHE.py script #33615
- File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): Dedicated data members for Run-3 CSC trigger primitives #33727
- File L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc modified in PR(s): Dedicated data members for Run-3 CSC trigger primitives #33727
- File L1Trigger/L1TTrackMatch/plugins/L1TrackJetProducer.cc modified in PR(s): Add init values for struct members to silence Arm warning #33742
- File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File RecoEgamma/EgammaElectronAlgos/src/GsfElectronAlgo.cc modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666
- File RecoEgamma/EgammaElectronProducers/plugins/GsfElectronProducer.cc modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666
- File RecoEgamma/EgammaPhotonProducers/src/GEDPhotonProducer.cc modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666
- File RecoHGCal/Configuration/python/RecoHGCal_EventContent_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File RecoHGCal/TICL/plugins/TrackstersFromSimClustersProducer.cc modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File RecoHGCal/TICL/python/EMStep_cff.py modified in PR(s): [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. #33645
- File RecoHGCal/TICL/python/HADStep_cff.py modified in PR(s): [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. #33645
- File RecoHGCal/TICL/python/MIPStep_cff.py modified in PR(s): [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. #33645
- File RecoHGCal/TICL/python/SimTracksters_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File RecoHGCal/TICL/python/TrkEMStep_cff.py modified in PR(s): [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. #33645
- File RecoHGCal/TICL/python/TrkStep_cff.py modified in PR(s): [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. #33645
- File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548, [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. #33645
- File RecoPixelVertexing/PixelVertexFinding/plugins/gpuVertexFinderImpl.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366
- File SimG4Core/Application/src/SteppingAction.cc modified in PR(s): Added a new run time protection for Full Sim #33746
- File Validation/Configuration/python/hgcalSimValid_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Validation/HGCalValidation/plugins/HGCalHitValidation.cc modified in PR(s): Fix compilation in Validation/HGCalValidation #33719
- File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548

cmsbuild · 2021-05-17T10:44:17Z

Pull request #33612 was updated. @SiewYan, @andrius-k, @gouskos, @chayanit, @wajidalikhan, @ianna, @kpedro88, @ErnestaP, @Martin-Grunewald, @rekovic, @tlampen, @alberto-sanchez, @pohsun, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @srimanob, @ahmad3213, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @smorovic, @davidlange6, @smuzaffar, @Dr15Jones, @jpata, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @ggovi, @qliphy, @fabiocos, @francescobrivio, @malbouis, @mkirsano, @jordan-martins, @kmaeshima, @emeschi, @silviodonato, @franzoni, @fgolf, @mariadalfonso, @rvenditti can you please check and sign again.

cmsbuild added this to the CMSSW_12_0_X milestone May 3, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels May 3, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 3, 2021

cmsbuild and others added 4 commits May 4, 2021 07:52

Merge pull request cms-sw#33597 from davidlange6/dl210501

8d1cd33

Validation/Geometry apply futurize stage1; use six.iteritems; use python3 for matplotlib

Fix typo in the fillDescriptions

6509a1f

Merged l1t-Victor_Nov_120X from repository cecilecaillol with cms-mer…

6f12b7f

…ge-topic

scram code format

954ad09

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 4, 2021

cmsbuild added tests-started and removed tests-pending labels May 4, 2021

sudhaahuja and others added 7 commits May 4, 2021 09:58

seeding algorithm updates for phi smoothing

55cf094

minor change

first version of working emulator with HLS

4815057

(cherry picked from commit 4e4619f)

first complete version of the cmssw emulator

eaeba68

(cherry picked from commit 3a9823f)

combine met emulator variants into a single plugin

30fa8fb

(cherry picked from commit 6d65423)

make table sizes configurable

03a332b

(cherry picked from commit 9d45304)

add emulator with new types

b83fdbb

(cherry picked from commit 95c3e28)

cleanup comments

9dcba0e

(cherry picked from commit f9e0c91)

cmsbuild and others added 3 commits May 15, 2021 17:05

Merge pull request cms-sw#33598 from fabiocos/fc-etllayout

a8ae543

MTD geometry and reconstruction: store ETL layout logic into MTDTopology, use for ETL layers navigation in reconstruction

Merged l1t-Victor_Nov_120X from repository cecilecaillol with cms-mer…

5f7883f

…ge-topic

switch from printf to LogDebug

41e6e2e

cecilecaillol closed this May 17, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 17, 2021

cecilecaillol mentioned this pull request May 17, 2021

L1 phase 2: produce CaloJet/Tau (corrected version) #33750

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L1 phase 2: produce CaloJet/Tau #33612

L1 phase 2: produce CaloJet/Tau #33612

cecilecaillol commented May 3, 2021

cmsbuild commented May 3, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

cecilecaillol commented May 4, 2021

cecilecaillol commented May 17, 2021

cmsbuild commented May 17, 2021

cmsbuild commented May 17, 2021

L1 phase 2: produce CaloJet/Tau #33612

L1 phase 2: produce CaloJet/Tau #33612

Conversation

cecilecaillol commented May 3, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 3, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

cecilecaillol commented May 4, 2021

cecilecaillol commented May 17, 2021

cmsbuild commented May 17, 2021

cmsbuild commented May 17, 2021