-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1 phase 2: produce CaloJet/Tau (corrected version) #33750
Conversation
…. Compiles correctly but still need to test that code is working (cherry picked from commit 6e20d41)
… by adding modified L1CaloJets_cff.py and adding name to L1CaloTowers in L1EGammaCrystalsEmulatorProducer.cc (cherry picked from commit d5b8025)
…mentalParams. Also modified L1CaloJetProducer to work with L1EGRateStudies plotting code (cherry picked from commit 9f24a9c)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33750/22696 |
A new Pull Request was created by @cecilecaillol for master. It involves the following packages: DataFormats/L1TCalorimeterPhase2 @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c1326/15129/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33750/22867 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c1326/15319/summary.html Comparison SummarySummary:
|
+l1 |
@srimanob Your comments have been addressed |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Updated Phase2 L1 CaloJet/Tau code from CMSSW_10_5_0_pre1 release to new data formats in more recent release and added minimum code necessary to produce CaloJets/Taus (L1Trigger/L1CaloTrigger/).
Same as #33612 but I made a github mistake in the other PR, which is closed now.
PR validation:
Same as #33612
if this PR is a backport please specify the original PR and why you need to backport that PR:
Same as #33612