Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniAOD Spring15pass2 7.4.X (collection of all PRs) #10649

Merged
merged 163 commits into from
Sep 2, 2015

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 9, 2015

As discussed in the RECO/AT meeting of August 6th, I've made a branch that merges all PRs for the 74X and ready for merge (i.e. once they're fully signed), so that they can be tested as a whole.
At the moment it includes: #10175 #10366 #10361 #10362 #10363 #10364 #10593
Summary on the MiniAODSpring15pass2 twiki

covarell and others added 30 commits July 13, 2015 19:26
…stinguish different cases of the MVA of the same class configured with different weights/tunings.
@gpetruc
Copy link
Contributor Author

gpetruc commented Aug 31, 2015

Uhm... #10649 itself should probably stay open.

On Mon, Aug 31, 2015 at 10:20 PM, David Lange notifications@github.com
wrote:

Closed #10649 #10649.


Reply to this email directly or view it on GitHub
#10649 (comment).

@davidlange6 davidlange6 reopened this Aug 31, 2015
@davidlange6
Copy link
Contributor

good point...

@davidlange6 davidlange6 reopened this Aug 31, 2015
…ssed in the PPD coord. meeting on 31.08.2015)
@gpetruc gpetruc force-pushed the MiniAODSpring15pass2-from74X branch from 88ba46d to 66c520b Compare August 31, 2015 20:47
@gpetruc
Copy link
Contributor Author

gpetruc commented Aug 31, 2015

As discussed today at the PPD coordination meeting, I have changed the default config of MiniAOD 74X to always re-run tau reconstruction.

@cmsbuild
Copy link
Contributor

Pull request #10649 was updated. @diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @slava77, @vadler, @mmusich can you please check and sign again.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

-1

Tested at: 66c520b
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS
---> test testJetMETCorrectionsType1MET had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10649/7775/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

@slava77
Copy link
Contributor

slava77 commented Sep 1, 2015

Exception Message:
python encountered the error: <class 'urllib2.URLError'>
<urlopen error [Errno -2] Name or service not known>

is this a real error?

@davidlange6
Copy link
Contributor

@slava77 - doesn't seem to be - but we have these errors all of a sudden

@davidlange6
Copy link
Contributor

Merging this PR for 7_4_11.

davidlange6 added a commit that referenced this pull request Sep 2, 2015
MiniAOD Spring15pass2 7.4.X (collection of all PRs)
@davidlange6 davidlange6 merged commit a208761 into cms-sw:CMSSW_7_4_X Sep 2, 2015
@gpetruc gpetruc deleted the MiniAODSpring15pass2-from74X branch September 30, 2015 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.