MiniAOD reprocessing (74X, BTV): SoftElectron tagger bugfixes

[ferencek]

Partial backport of #9673

This PR is part of preparations for possible MiniAOD reprocessing of the Spring15 MC and 50ns Run2012B Data in 74X. More info at the following links:

• https://hypernews.cern.ch/HyperNews/CMS/get/physics-validation/2445.html
• https://twiki.cern.ch/twiki/bin/view/CMS/MiniAODSpring15pass2#BTV

[slava77]

@cmsbuild please test

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

MiniAOD reprocessing (74X, BTV): SoftElectron tagger bugfixes

It involves the following packages:

RecoBTag/SoftLepton

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 0d095d6
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 24-Jul-2015 23:35:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1893722
   [1] Running path 'pathALCARECOTkAlMinBiasHI'
   [2] Calling event method for module AlignmentTrackSelectorModule/'ALCARECOTkAlMinBiasHI'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: hiGeneralTracks
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 24-Jul-2015 23:36:57 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'pathALCARECOTkAlZMuMu'
   [2] Calling event method for module MuonSelector/'ALCARECOTkAlZMuMuGoodMuons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: muons
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log
----- Begin Fatal Exception 24-Jul-2015 23:37:02 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'pathHotlineSkimCaloMET'
   [2] Calling event method for module VertexSelector/'pvFilterHotLine'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: offlinePrimaryVertices
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 24-Jul-2015 23:37:23 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 194533 lumi: 329 event: 461582793
   [1] Running path 'pathALCARECOSiStripCalMinBias'
   [2] Calling event method for module AlignmentTrackSelectorModule/'ALCARECOSiStripCalMinBias'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: generalTracks
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10363/139/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10363/191514/summary.html

[slava77]

modulo the performance consistency problem this is +1

for #10363 0d095d6

• The code changes are affecting the regular/underlying pp reco and the implementation does not really allow a switch from one version to another, which introduces inconsistency with the mainstream 74X reconstruction. This is a topic for discussion in a separate meeting (not this PR thread)
• I confirmed by cherry-picking these commits that the code changes in this PR are the same as what we have in 75X (cherry-pick in 75X introduces zero diffs to 75X)
• jenkins tests pass and comparisons with baseline show differences only in softPFElectronBJetTags (larger diffs) and in pfCombinedMVA (smaller diffs)

[slava77]

+1

based on review above and the re-miniAOD discussion.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

closing PRs included in #10649