Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiniAOD Spring15pass2 7.4.X (collection of all PRs) #10649

Merged
merged 163 commits into from
Sep 2, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
163 commits
Select commit Hold shift + click to select a range
93d87df
added GenLumiInfoProduct for a posteriori cross-section calculation
covarell Jul 13, 2015
be8bca9
Whitelist IVF candidates for detail IP storage
arizzi Jul 7, 2015
8df5f3e
fix parenthesis bug
arizzi Jul 8, 2015
4a58c39
enable CSVv2 in combinedMVA instead of CSV
pvmulder May 21, 2015
b0ce96d
switching soft lepton taggers to the TMVAEvaluator class
ferencek Jun 18, 2015
0d095d6
also flipping sign of the electron 2D IP
ferencek Jun 18, 2015
26dbd70
removing CSV+SL and adding SL taggers to the default PAT jet configur…
ferencek Jul 12, 2015
e17026c
added sorting of mother and daughter RefVectors
ferencek Jun 21, 2015
b0ae877
reintroduced correct handling of infinite mother/daughter loops that got
ferencek Jul 3, 2015
8098e8e
switch to GenJetsNoNu
ahinzmann Jul 29, 2015
e3c8e0f
use a global cache for MVA Estimators
lgray Aug 3, 2015
38ce227
fix buildfile errors and revert to older version of GBR forest
lgray Aug 4, 2015
ab65c7a
make sure to use objects from global cache everywhere in MVAValueMapP…
lgray Aug 4, 2015
83e8092
pileup summary info slimmer for miniaod
lgray Aug 5, 2015
135994e
moving scrapingfilter, removing wrong version of PV filter
schoef Aug 6, 2015
ae430da
small
schoef Aug 6, 2015
542a401
fix met filter sequence
schoef Jul 28, 2015
1fe80b6
resolved
schoef Jul 31, 2015
fb7df04
adjust EcalDeadCellBoundaryEnergyFilter rechit flags
schoef Aug 1, 2015
d629849
adjust EcalDeadCellTriggerPrimitiveFilter threshold to run-II
schoef Aug 1, 2015
0fc43d6
removing EcalDeadCellDeltaRFilter_cfi.py because module is not in the…
schoef Aug 1, 2015
c30debc
resolved
schoef Aug 1, 2015
e7c7c65
resolved
schoef Aug 5, 2015
46cfc91
added boundary filter to allMetFilters
schoef Aug 6, 2015
79e14c5
fixing metFilters_cff.py
schoef Aug 6, 2015
23682aa
adding back the hbhe iso filter
schoef Aug 6, 2015
1d43e7d
fixing HBHE Iso noise filter
schoef Aug 6, 2015
120e850
fixing HBHE
schoef Aug 6, 2015
d3073dd
New MVA IDs from Rong-Shyang for Spring15: V1 for 50ns and V0 for 25ns
ikrav Jul 20, 2015
00c7d42
Added the mvaTag field to the MVA estimator, plus dependencies, to di…
ikrav Jul 20, 2015
5fc4609
Added the new mvaTag field to the most recent MVA configuratoins
ikrav Jul 20, 2015
d15eeea
Create effAreaNeutralHadrons_cone03_pf_50ns.txt
skyriacoCMS Jul 29, 2015
563358a
Create effAreaPhotons_cone03_pfPhotons_50ns.txt
skyriacoCMS Jul 29, 2015
c0783af
Create effAreaPhotons_cone03_pfChargedHadrons_50ns.txt
skyriacoCMS Jul 29, 2015
500c1a8
Rename effAreaNeutralHadrons_cone03_pf_50ns.txt to effAreaPhotons_con…
skyriacoCMS Jul 29, 2015
073d14e
Create cutBasedPhotonID_Spring15_50ns_V1_cff.py
skyriacoCMS Jul 29, 2015
b8f5d3b
New effective areas for electrons for Spring15 25ns abd 50ns
ikrav Jul 31, 2015
5a2ecb2
The implementation of the new 25ns non-triggering MVA tuned by P.Piga…
ikrav Jul 31, 2015
1c6a3e2
Renamed the two files of the new Spring15 electron non-trig MVA into …
ikrav Jul 31, 2015
0c94515
Weights and new python configuration for the new non-trig 25ns Spring…
ikrav Jul 31, 2015
067dddd
A few fixes
ikrav Aug 1, 2015
9b9b6f8
a change to the Reader options
ikrav Aug 1, 2015
24a7a99
update Spring15NonTrig for electrons to threadsafe base class
lgray Aug 4, 2015
f767c40
Spring15 50ns ID from 31072015 presentation (Rami)
lgray Aug 4, 2015
a46cc1c
Set Spring15_25ns MVA to actual values for WP90 from P. Pigard
lgray Aug 4, 2015
cc7266c
add 50ns mva Photon ID V2
lgray Aug 4, 2015
f25e572
Fix implementation of @skyriacoCMS photon ID, fix bug in lower level …
lgray Aug 4, 2015
d252d94
update MiniAOD tools to the latest EGM-blessed IDs
lgray Aug 4, 2015
f6958e1
invalidate deprecated IDs
lgray Aug 4, 2015
37e1210
fix typos in Spring15 ID cutbased, validation now checks out
lgray Aug 4, 2015
a036c51
remove HEEP51 from MiniAOD and deprecate it
lgray Aug 4, 2015
ec765a5
turn off embedding of vid::CutFlowResult in MiniAOD pat candidates
lgray Aug 5, 2015
502a0aa
EGM Object Modifiers for MiniAOD reprocessing
lgray Aug 6, 2015
883cbdf
add wp80 to Spring15 electron mva ID
lgray Aug 6, 2015
2afb4ef
Merged refs/pull/10447/head from repository cms-sw
gpetruc Aug 9, 2015
aae79e0
Merged refs/pull/10175/head from repository cms-sw
gpetruc Aug 9, 2015
8edd319
Merged refs/pull/10366/head from repository cms-sw
gpetruc Aug 9, 2015
cc23f13
Merged refs/pull/10361/head from repository cms-sw
gpetruc Aug 9, 2015
3354959
Merged refs/pull/10362/head from repository cms-sw
gpetruc Aug 9, 2015
33ff2ac
Merged refs/pull/10363/head from repository cms-sw
gpetruc Aug 9, 2015
480e555
Merged refs/pull/10364/head from repository cms-sw
gpetruc Aug 9, 2015
061633d
Merged refs/pull/10593/head from repository cms-sw
gpetruc Aug 9, 2015
fad9bac
add photons with pt 10-14 GeV that pass charged hadron isolation < 10…
cmkuo Aug 10, 2015
f733fb3
remove unused variable per clang warnings
lgray Aug 4, 2015
7e024e1
add photons with pt beween 10 and 14 GeV with H/E < 0.15 and charged …
cmkuo Aug 10, 2015
8f981eb
fix a potential bug with photon pt threshold
cmkuo Aug 11, 2015
d55edc6
Merged refs/pull/10556/head from repository cms-sw
gpetruc Aug 11, 2015
2bf2168
use constants instead of magic numbers eta cut
lgray Aug 12, 2015
2c0dc5f
fix semicolon;
lgray Aug 13, 2015
b4877ad
reduce copy/pasta in IsolationModifier
lgray Aug 13, 2015
03dfe6d
move slimmedAddPileupInfo to miniAOD_customizeMC
lgray Aug 13, 2015
6a257dc
prototype for physics based flavour in MiniAOD
ahinzmann Jul 30, 2015
4d2cac3
make work for Pythia8 ttbar
ahinzmann Jul 30, 2015
783d1eb
use prunedGenParticles as input
ahinzmann Jul 30, 2015
37bb299
add also lepton matching
ahinzmann Jul 31, 2015
21a7db5
Dinkos comments
ahinzmann Aug 3, 2015
dabec7b
Merged refs/pull/10363/head from repository cms-sw
ferencek Aug 13, 2015
ee37259
catch and return a TMVA::IMethod pointer
ferencek Aug 1, 2015
60cd78d
initial attempt at adding GBRForest to the TMVAEvaluator class
ferencek Aug 1, 2015
7785f71
now keeping track of the order of input variables, added option to us…
ferencek Aug 2, 2015
d650108
added possibility to use GBRForest from an external source
ferencek Aug 2, 2015
05a03ba
declared JetTagComputerRecord dependent on the GBRWrapperRcd
ferencek Aug 3, 2015
8c091ad
switching the soft electron tagger to using the GBRForest
ferencek Aug 3, 2015
f0915d5
switching the soft muon tagger to using the GBRForest
ferencek Aug 4, 2015
513d10b
making the evaluate() method const
ferencek Aug 10, 2015
1a38bf9
splitting the evaluate() method into evaluateTMVA() and evaluateGBRFo…
ferencek Aug 11, 2015
b6d300a
removed mutex locking from soft lepton tagger since now done in the T…
ferencek Aug 11, 2015
f2a7d20
introduced an explicit CondDB usage switch
ferencek Aug 11, 2015
4d2cda8
switching to std::unique_ptr
ferencek Aug 11, 2015
fb39c3e
Merge tag 'CMSSW_7_4_9' into MiniAODSpring15pass2-from74X
gpetruc Aug 14, 2015
336c214
Merged refs/pull/10593/head from repository cms-sw
gpetruc Aug 14, 2015
d8b120e
Merged refs/pull/10667/head from repository cms-sw
gpetruc Aug 14, 2015
1d4d7e1
adjust thresholds
ahinzmann Aug 13, 2015
eb41b79
lower ak8 threshold
ahinzmann Aug 14, 2015
6564dc9
Merged refs/pull/10598/head from repository cms-sw
gpetruc Aug 17, 2015
27df340
Merged refs/pull/10784/head from repository cms-sw
gpetruc Aug 17, 2015
15bad0c
Merged refs/pull/10604/head from repository cms-sw
gpetruc Aug 18, 2015
0c7c114
Merged MiniAODSpring15pass2-from74X from repository gpetruc
nhanvtran Aug 20, 2015
bed926c
Added python for cut-based photon MVA Spring15 25ns V2 and deprecated…
ikrav Aug 17, 2015
4803664
A new cut based electron ID, 25ns Spring15 first version
ikrav Aug 17, 2015
6cb254c
Fixed a typo in the eta ranges
ikrav Aug 17, 2015
cef5818
update embedding to V2
lgray Aug 18, 2015
0533d42
update IDs in MiniAOD config
lgray Aug 18, 2015
8c35330
backported from 75x
nhanvtran Aug 20, 2015
e6b45b0
Add L1 prescales
gpetruc Aug 20, 2015
c1b9d1a
Merged refs/pull/10598/head from repository cms-sw
gpetruc Aug 20, 2015
44975c6
Merged refs/pull/10750/head from repository cms-sw
gpetruc Aug 20, 2015
f205e7f
update checksums
nhanvtran Aug 20, 2015
a4e2d76
update checksums
nhanvtran Aug 20, 2015
bc9f424
Merge tag 'CMSSW_7_4_10_patch1' into MiniAODSpring15pass2-from74X
gpetruc Aug 21, 2015
5beded2
Merge tag 'MiniAODSpring15pass2-from74X-v1.10' into MiniAODSpring15pa…
gpetruc Aug 21, 2015
0857940
Add the l1 prescales to the event content as well
gpetruc Aug 21, 2015
51da8e3
Merged refs/pull/10551/head from repository cms-sw
gpetruc Aug 21, 2015
c317927
Merged refs/pull/10598/head from repository cms-sw
lgray Aug 24, 2015
aee45f1
first implementation
matteosan1 Aug 7, 2015
3cee798
final update
matteosan1 Aug 8, 2015
7012ec2
fix memory leak and tag label
matteosan1 Aug 11, 2015
8fd60fc
address most of code review comments (some are left for another PR)
lgray Aug 18, 2015
1240c61
fix issues spotted by Jean-Baptiste
lgray Aug 18, 2015
372bca1
actually assign the calculated weight
lgray Aug 18, 2015
23d5368
remove ESPrefers for GBRD conditions
lgray Aug 18, 2015
a0a51c3
more code review
lgray Aug 19, 2015
de7d89a
make full5x5 or fraction-ified shower shapes configurable in regressions
lgray Aug 19, 2015
895fafe
revert use of c++14 for 74X
lgray Aug 20, 2015
bf1d12b
Adding e/gamma regression from Ecal Multifit in Run1/Run2 GTs (74X)
mmusich Aug 20, 2015
6668bb7
change photon regressions back to fractionized shower shapes (confirm…
lgray Aug 24, 2015
f94a1dc
revert everything to fractionized shower shapes for regressions
lgray Aug 24, 2015
87ebec5
- dynamic strip reconstruction for Yuta
May 19, 2015
4742d79
fixed typo in discriminator name
May 19, 2015
7c658b7
bug-fix in storing of (raw) footprint correction
May 19, 2015
6f5d602
- store neutral pileup weighted isolation pT sum
May 19, 2015
e54a3a6
added pileup weighted neutral isolation
May 19, 2015
3204063
fixed typo in discriminator name
May 19, 2015
de9331a
updated parameters for dynamic strip reconstruction
May 24, 2015
8e114c2
sutract 2 GeV from k offset values (except for 3prong0pi0), as recomm…
Jun 1, 2015
b92676f
New cleaner module that works also if tau is made up of combination of
anehrkor May 29, 2015
6a0927a
added functionality to make tau footprint correction dependent on tauPt
Jun 3, 2015
6c0970e
tightened cut on pTouter from 0.20*tauPt to 0.10*tauPt
Jun 9, 2015
7ce036f
apply cut on ptOuter also in case of HPS combined islation 3-hit disc…
Jun 9, 2015
7ed86f7
- updated deltaBeta correction factor to 0.2
Jun 10, 2015
51106a1
updates to tau vertex producers from Arun
Jul 8, 2015
0f9d847
updated patTau selection to use new discriminators
Jul 22, 2015
2b9df30
Added missing discriminators to updateHPSPFTaus_cff.py - their absenc…
andrewj314 Jul 16, 2015
068059b
Added import statements whose absence was causing the unit tests to fail
andrewj314 Jul 19, 2015
332ef14
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
andrewj314 Aug 6, 2015
d57288b
Added fillDescriptions() method, reverted HLT dumps to previous versi…
andrewj314 Aug 9, 2015
7c03241
Added Christian's alternate fix to the HLT issues. Now passing all te…
andrewj314 Aug 11, 2015
1f90487
Per Slava's suggestion, removed modules from cms.Sequence and added t…
andrewj314 Aug 13, 2015
f298382
Attempting to implement Slava's suggestions after his review of PR 10…
andrewj314 Aug 15, 2015
79a5b3a
Applied Slava's suggestions in PR 10605+10802, now passing all tests!
andrewj314 Aug 16, 2015
09467ef
Bugfix adding absolute value to deltaPhi, changing BOOSTFOREACH loops…
andrewj314 Aug 22, 2015
a95733f
added cut that each tau has at least one pixel hits (for at least one…
Mar 5, 2015
26567f5
Merged refs/pull/10760/head from repository cms-sw
gpetruc Aug 28, 2015
4f78f40
Don't run ak4PFJets (fix RecoJets/JetProducers/python/ak4PFJetsPuppi_…
gpetruc Aug 28, 2015
e414f46
Don't re-run pfMet (miniAOD_tools)
gpetruc Aug 28, 2015
40f4d30
Don't rerun ak8PFJetsCHSSoftDrop (PhysicsTools/PatAlgos/python/slimmi…
gpetruc Aug 28, 2015
c84b62d
Don't load particleFlowPtrs (PhysicsTools/PatAlgos/python/recoLayer0/…
gpetruc Aug 28, 2015
a0cae3f
Don't load particleFlowPtrs (JetMETCorrections/Type1MET/python/correc…
gpetruc Aug 28, 2015
0264dae
Merged refs/pull/10895/head from repository cms-sw
gpetruc Aug 31, 2015
7d7e812
Merged refs/pull/10943/head from repository cms-sw
gpetruc Aug 31, 2015
7eb29ea
Merged refs/pull/10693/head from repository cms-sw
gpetruc Aug 31, 2015
a3625da
Merge branch 'miniAOD_should_not_rerun_reco_74X_on10649' into MiniAOD…
gpetruc Aug 31, 2015
66c520b
In 74X, always re-run Tau reconstruction as part of MiniAOD (as discu…
gpetruc Aug 31, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions CalibMuon/DTCalibration/python/ALCARECODtCalibHI_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,6 @@
dt4DSegmentsNoWire.Reco4DAlgoConfig.recAlgoConfig.tTrigModeConfig.doWirePropCorrection = False
dt4DSegmentsNoWire.Reco4DAlgoConfig.Reco2DAlgoConfig.recAlgoConfig.tTrigModeConfig.doWirePropCorrection = False

#this is to select collisions
primaryVertexFilter = cms.EDFilter("VertexSelector",
src = cms.InputTag("hiSelectedVertex"),
cut = cms.string("!isFake && ndof > 4 && abs(z) <= 15 && position.Rho <= 2"),
filter = cms.bool(True),
)

noscraping = cms.EDFilter("FilterOutScraping",
applyfilter = cms.untracked.bool(True),
debugOn = cms.untracked.bool(False),
numtrack = cms.untracked.uint32(10),
thresh = cms.untracked.double(0.25)
)

#seqALCARECODtCalibHI = cms.Sequence(ALCARECODtCalibHIHLTFilter * primaryVertexFilter * DTCalibMuonSelection * dt4DSegmentsNoWire)

seqALCARECODtCalibHI = cms.Sequence(ALCARECODtCalibHIHLTFilter * dt4DSegmentsNoWire)
13 changes: 1 addition & 12 deletions CalibMuon/DTCalibration/python/ALCARECODtCalib_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,6 @@
dt4DSegmentsNoWire.Reco4DAlgoConfig.Reco2DAlgoConfig.recAlgoConfig.tTrigModeConfig.doWirePropCorrection = False

#this is to select collisions
primaryVertexFilter = cms.EDFilter("VertexSelector",
src = cms.InputTag("offlinePrimaryVertices"),
cut = cms.string("!isFake && ndof > 4 && abs(z) <= 15 && position.Rho <= 2"), # tracksSize() > 3 for the older cut
filter = cms.bool(True), # otherwise it won't filter the events, just produce an empty vertex collection.
)

noscraping = cms.EDFilter("FilterOutScraping",
applyfilter = cms.untracked.bool(True),
debugOn = cms.untracked.bool(False),
numtrack = cms.untracked.uint32(10),
thresh = cms.untracked.double(0.25)
)
from RecoMET.METFilters.metFilters_cff import primaryVertexFilter, noscraping

seqALCARECODtCalib = cms.Sequence(primaryVertexFilter * noscraping * ALCARECODtCalibHLTFilter * DTCalibMuonSelection * dt4DSegmentsNoWire)
1 change: 0 additions & 1 deletion CommonTools/ParticleFlow/python/pfTaus_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
pfTauTagInfoProducer.PFCandidateProducer = jetConfig.ak4PFJets.src
pfTauTagInfoProducer.PFJetTracksAssociatorProducer = 'pfJetTracksAssociatorAtVertex'


pfTausPreSequence = cms.Sequence(
pfJetTracksAssociatorAtVertex +
pfTauPFJets08Region +
Expand Down
14 changes: 12 additions & 2 deletions CommonTools/PileupAlgos/interface/PuppiAlgo.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class PuppiAlgo{
void computeMedRMS(const unsigned int &iAlgo,const double &iPVFrac);
//Get the Weight
double compute(std::vector<double> const &iVals,double iChi2) const;
const std::vector<float> & alphas(){ return fPups; }
//Helpers
inline double ptMin() const { return fPtMin; }
inline double etaMin() const { return fEtaMin; }
Expand All @@ -26,13 +27,24 @@ class PuppiAlgo{
inline double coneSize ( unsigned int iAlgo) const { return fConeSize.at(iAlgo); }
inline double neutralPt (int iNPV) const { return fNeutralPtMin + iNPV * fNeutralPtSlope; }

inline double rms( unsigned int i ) const {return fRMS[i];}
inline double median( unsigned int i ) const {return fMedian[i];}

private:
unsigned int fNAlgos;
float fEtaMax;
float fEtaMin;
float fPtMin ;
double fNeutralPtMin;
double fNeutralPtSlope;

double fRMSEtaSF;
double fMedEtaSF;
double fEtaMaxExtrap;

std::vector<double> fRMS;
std::vector<double> fMedian;

std::vector<float> fPups;
std::vector<float> fPupsPV;
std::vector<int> fAlgoId;
Expand All @@ -42,8 +54,6 @@ class PuppiAlgo{
std::vector<double> fConeSize;
std::vector<double> fRMSPtMin;
std::vector<double> fRMSScaleFactor;
std::vector<double> fRMS;
std::vector<double> fMedian;
std::vector<double> fMean;
std::vector<int> fNCount;
};
Expand Down
18 changes: 17 additions & 1 deletion CommonTools/PileupAlgos/interface/PuppiContainer.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,25 +37,41 @@ class PuppiContainer{
PuppiContainer(const edm::ParameterSet &iConfig);
~PuppiContainer();
void initialize(const std::vector<RecoObj> &iRecoObjects);
void setNPV(int iNPV){ fNPV = iNPV; }

std::vector<fastjet::PseudoJet> const & pfParticles() const { return fPFParticles; }
std::vector<fastjet::PseudoJet> const & pvParticles() const { return fChargedPV; }
std::vector<double> const & puppiWeights() ;
std::vector<double> const & puppiWeights();
const std::vector<double> & puppiRawAlphas(){ return fRawAlphas; }
const std::vector<double> & puppiAlphas(){ return fVals; }
// const std::vector<double> puppiAlpha () {return fAlpha;}
const std::vector<double> & puppiAlphasMed() {return fAlphaMed;}
const std::vector<double> & puppiAlphasRMS() {return fAlphaRMS;}

int puppiNAlgos(){ return fNAlgos; }
std::vector<fastjet::PseudoJet> const & puppiParticles() const { return fPupParticles;}

protected:
double goodVar (fastjet::PseudoJet const &iPart,std::vector<fastjet::PseudoJet> const &iParts, int iOpt,double iRCone);
void getRMSAvg (int iOpt,std::vector<fastjet::PseudoJet> const &iConstits,std::vector<fastjet::PseudoJet> const &iParticles,std::vector<fastjet::PseudoJet> const &iChargeParticles);
void getRawAlphas (int iOpt,std::vector<fastjet::PseudoJet> const &iConstits,std::vector<fastjet::PseudoJet> const &iParticles,std::vector<fastjet::PseudoJet> const &iChargeParticles);
double getChi2FromdZ(double iDZ);
int getPuppiId ( float iPt, float iEta);
double var_within_R (int iId, const std::vector<fastjet::PseudoJet> & particles, const fastjet::PseudoJet& centre, double R);

bool fPuppiDiagnostics;
std::vector<RecoObj> fRecoParticles;
std::vector<fastjet::PseudoJet> fPFParticles;
std::vector<fastjet::PseudoJet> fChargedPV;
std::vector<fastjet::PseudoJet> fPupParticles;
std::vector<double> fWeights;
std::vector<double> fVals;
std::vector<double> fRawAlphas;
std::vector<double> fAlphaMed;
std::vector<double> fAlphaRMS;

bool fApplyCHS;
bool fInvert;
bool fUseExp;
double fNeutralMinPt;
double fNeutralSlope;
Expand Down
2 changes: 1 addition & 1 deletion CommonTools/PileupAlgos/interface/RecoObj.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class RecoObj
{}
~RecoObj(){}

float pt, eta, phi, m; // kinematics
float pt, eta, phi, m, rapidity; // kinematics
int id;
int pfType;
int vtxId; // Vertex Id from Vertex Collection
Expand Down
Loading