Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiniAOD reprocessing (74X, BTV): Removing CSV+SL and adding SL taggers to the default PAT jet configuration #10364

Closed
wants to merge 1 commit into from
Closed

MiniAOD reprocessing (74X, BTV): Removing CSV+SL and adding SL taggers to the default PAT jet configuration #10364

wants to merge 1 commit into from

Conversation

ferencek
Copy link
Contributor

Backport of #10157

This PR is part of preparations for possible MiniAOD reprocessing of the Spring15 MC and 50ns Run2012B Data in 74X. More info at the following links:

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jul 24, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

MiniAOD reprocessing (74X, BTV): Removing CSV+SL and adding SL taggers to the default PAT jet configuration

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 26dbd70
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 25-Jul-2015 00:00:04 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 182124 lumi: 40 event: 1893722
   [1] Running path 'pathALCARECOTkAlMinBiasHI'
   [2] Calling event method for module AlignmentTrackSelectorModule/'ALCARECOTkAlMinBiasHI'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: hiGeneralTracks
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log
----- Begin Fatal Exception 25-Jul-2015 00:01:31 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'pathHotlineSkimCaloMET'
   [2] Calling event method for module VertexSelector/'pvFilterHotLine'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: offlinePrimaryVertices
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 25-Jul-2015 00:01:29 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'pathALCARECOTkAlZMuMu'
   [2] Calling event method for module MuonSelector/'ALCARECOTkAlZMuMuGoodMuons'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: muons
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 25-Jul-2015 00:02:29 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 194533 lumi: 329 event: 461582793
   [1] Running path 'pathALCARECOSiStripCalMinBias'
   [2] Calling event method for module AlignmentTrackSelectorModule/'ALCARECOSiStripCalMinBias'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: generalTracks
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10364/71/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10364/6875/summary.html

There are some workflows for which there are errors in the baseline:
25202.0 step 2
50202.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@gpetruc gpetruc mentioned this pull request Aug 9, 2015
Merged
@davidlange6
Copy link
Contributor

closing PRs included in #10649

@ferencek ferencek deleted the SoftLeptonTaggersInMiniAOD_from-CMSSW_7_4_7 branch September 4, 2015 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@ferencek @cmsbuild @slava77 @monttj @davidlange6