Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] Disable the use of GNU unique symbols #8381

Closed
wants to merge 1 commit into from
Closed

[do not merge] Disable the use of GNU unique symbols #8381

wants to merge 1 commit into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 14, 2023

From man gcc:

-fno-gnu-unique
On systems with recent GNU assembler and C library, the C++ compiler uses the "STB_GNU_UNIQUE" binding to make sure that definitions of template static data members and static local variables in inline functions are unique even in the presence of "RTLD_LOCAL"; this is necessary to avoid problems with a library used by two different "RTLD_LOCAL" plugins depending on a definition in one of them and therefore disagreeing with the other one about the binding of the symbol. But this causes "dlclose" to be ignored for affected DSOs; if your program relies on reinitialization of a DSO via "dlclose" and "dlopen", you can use -fno-gnu-unique.

Since CMSSW loads plugins using RTLD_GLOBAL, not RTLD_LOCAL, we could check the impact of disabling the GNU unique extension, that does not seem to be supported by clang.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2023

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31264/summary.html
COMMIT: 0359cae
CMSSW: CMSSW_13_1_X_2023-03-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8381/31264/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31264/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31264/git-merge-result

Build

I found compilation error when building:

>> Subsystem SimRomanPot built
Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/CUDAWrapper/src/HeterogeneousTestCUDAWrapper/libHeterogeneousTestCUDAWrapper_nv.a to productstore area:
Copying tmp/el8_amd64_gcc11/src/HeterogeneousTest/ROCmWrapper/src/HeterogeneousTestROCmWrapper/libHeterogeneousTestROCmWrapper_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc11/src/HeterogeneousTest/ROCmWrapper/src/HeterogeneousTestROCmWrapper/libHeterogeneousTestROCmWrapper_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc11/src/HeterogeneousTest/ROCmWrapper/src/HeterogeneousTestROCmWrapper/libHeterogeneousTestROCmWrapper_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1742: tmp/el8_amd64_gcc11/src/HeterogeneousTest/ROCmWrapper/src/HeterogeneousTestROCmWrapper/libHeterogeneousTestROCmWrapper_rocm.a] Error 1
>> Entering Package FWCore/Version
>> Leaving Package FWCore/Version
>> Package FWCore/Version built
Entering library rule at FWCore/Version
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-2300/src/FWCore/Version/src/GetFileFormatVersion.cc

@fwyzard fwyzard force-pushed the IB/CMSSW_13_1_X/master_no_gnu_unique branch from 0359cae to 52a0bb8 Compare March 14, 2023 21:35
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2023

please test

@cmsbuild
Copy link
Contributor

Pull request #8381 was updated.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31277/summary.html
COMMIT: 52a0bb8
CMSSW: CMSSW_13_1_X_2023-03-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8381/31277/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31277/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31277/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testhep_ml had ERRORS

Comparison Summary

Summary:

  • You potentially removed 170 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 422 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550721
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 15, 2023

image

spurious failure ?

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 15, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e5ac/31279/summary.html
COMMIT: 52a0bb8
CMSSW: CMSSW_13_1_X_2023-03-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8381/31279/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 188 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550728
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard fwyzard closed this Mar 21, 2023
@fwyzard fwyzard deleted the IB/CMSSW_13_1_X/master_no_gnu_unique branch March 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwyzard @cmsbuild @smuzaffar