Payload Inspector plugin for Jet Resolution and SF #41008

yuanchao · 2023-03-09T10:55:40Z

PR description:

For the issue of wrong GT of Jet Resolution used, a payload inspector plugin is created for detector experts to check online. Individual histograms are available in Histogram1D class. Summary plots on Jet Resolution and SF are in PlotImage class.

PR validation:

Code checked with getPayloadData.py locally.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport.

cmsbuild · 2023-03-09T10:55:57Z

@yuanchao, CMSSW_13_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2023-03-09T11:03:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34525

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34525/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34525/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34525/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34525/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-03-09T15:07:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34530

This PR adds an extra 8KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34530/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34530/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34530/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34530/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-03-09T15:46:36Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34532

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34532/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34532/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34532/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34532/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc

cmsbuild · 2023-03-10T08:34:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34542

This PR adds an extra 12KB to repository

tvami · 2023-03-14T01:41:42Z

CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:49:47: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:49:56: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:101:53: warning: field 'MIN_PT' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:101:61: warning: field 'MAX_PT' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:56: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:65: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:56: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:65: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:56: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:65: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:49:47: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:49:56: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:101:53: warning: field 'MIN_PT' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:101:61: warning: field 'MAX_PT' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:56: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:65: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:56: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:65: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:56: warning: field 'MIN_ETA' is uninitialized when used here [-Wuninitialized]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-13-1100/src/CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc:262:65: warning: field 'MAX_ETA' is uninitialized when used here [-Wuninitialized]

cmsbuild · 2023-03-14T11:47:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41008/34620

This PR adds an extra 12KB to repository

cmsbuild · 2023-03-14T11:48:18Z

Pull request #41008 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

tvami · 2023-03-14T12:12:22Z

@cmsbuild , please test

cmsbuild · 2023-03-14T14:41:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a0f1e/31265/summary.html
COMMIT: 48f697c
CMSSW: CMSSW_13_1_X_2023-03-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41008/31265/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3550756
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3550727
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2023-03-14T17:56:22Z

+db

unit test pass https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a0f1e/31265/unitTests/src/CondCore/JetMETPlugins/test/testJetResolutionPayloadInspector/testing.log
there is a few things to follow up, but given that the JEC plots need to be added, maybe those changes can be done in the next PR

cmsbuild · 2023-03-14T17:56:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-03-14T19:12:42Z

+1

mmusich

@yuanchao please try to address these in a follow-up

CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc

CondCore/JetMETPlugins/test/BuildFile.xml

cmsbuild changed the base branch from CMSSW_13_1_X to master March 9, 2023 10:55

cmsbuild added this to the CMSSW_13_1_X milestone Mar 9, 2023

cmsbuild added db-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 9, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 9, 2023

yuanchao force-pushed the pi_jetres branch from 9d90385 to 0c3b8a9 Compare March 9, 2023 14:53

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 9, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 9, 2023

yuanchao force-pushed the pi_jetres branch from 0c3b8a9 to 6b23b50 Compare March 9, 2023 15:38

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 9, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 9, 2023

mmusich reviewed Mar 9, 2023

View reviewed changes

CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc Outdated Show resolved Hide resolved

yuanchao force-pushed the pi_jetres branch from 6b23b50 to 550e49b Compare March 10, 2023 08:27

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 10, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 10, 2023

cmsbuild added tests-rejected and removed tests-started labels Mar 13, 2023

fix bin range constants

48f697c

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Mar 14, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 14, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 14, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2023

cmsbuild added fully-signed db-approved and removed db-pending pending-signatures labels Mar 14, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 14, 2023

cmsbuild merged commit ac6fa58 into cms-sw:master Mar 14, 2023

mmusich reviewed Mar 14, 2023

View reviewed changes

CondCore/JetMETPlugins/plugins/JetResolution_PayloadInspector.cc Show resolved Hide resolved

CondCore/JetMETPlugins/test/BuildFile.xml Show resolved Hide resolved

cmsbuild mentioned this pull request Mar 15, 2023

[do not merge] Disable the use of GNU unique symbols cms-sw/cmsdist#8381

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Payload Inspector plugin for Jet Resolution and SF #41008

Payload Inspector plugin for Jet Resolution and SF #41008

yuanchao commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 10, 2023

tvami commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

tvami commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

tvami commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

rappoccio commented Mar 14, 2023

mmusich left a comment

Payload Inspector plugin for Jet Resolution and SF #41008

Payload Inspector plugin for Jet Resolution and SF #41008

Conversation

yuanchao commented Mar 9, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 10, 2023

tvami commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

tvami commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

Comparison Summary

tvami commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

rappoccio commented Mar 14, 2023

mmusich left a comment

Choose a reason for hiding this comment