-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the beam spot configuration of the Phase-2 HLT menu more consistent #41047
Conversation
These changes - remove the hltScalersRawToDigi and hltOnlineBeamSpotProducer modules; - rename the offlineBeamSpotProducer module to hltOnlineBeamSpotProducer; - replace explicit instances of the hltOnlineBeamSpotProducer with the HLTBeamSpotTask; - update all modules to use the hltOnlineBeamSpotProducer as input.
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41047/34610
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42a88d/31254/summary.html Comparison SummarySummary:
|
It has been discussed at the HLT Upgrade meeting and it is agreed to get in |
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
I forced github to re-evaluate the merge, now it shows a single commit. |
+1 |
PR description:
Make the beam spot configuration of the Phase-2 HLT menu more consistent.
Currently, part of the modules use the
offlineBeamSpotProducer
, and part use thehltOnlineBeamSpotProducer
.Moreover it is not clear if the
hltOnlineBeamSpotProducer
is working correctly in the Phase-2 configuration.These changes:
hltScalersRawToDigi
andhltOnlineBeamSpotProducer
modules;offlineBeamSpotProducer
module tohltOnlineBeamSpotProducer
;hltOnlineBeamSpotProducer
with theHLTBeamSpotTask
;hltOnlineBeamSpotProducer
as input.PR validation:
runTheMAtrix.py -l 20834.76
runs.Note that this PR builds on top, and so includes, #40912 .