-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unit test: avoid creating data files in src tree #41044
fix unit test: avoid creating data files in src tree #41044
Conversation
hopefully this is the last unit test which was blocking the enabling of |
@cms-sw/db-l2 , if you do not like the extra script |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41044/34597
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I think that's fine as you did it |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-647e6e/31253/summary.html Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This change allows the unit test
TestCondFormatsJetMETObjectsJetCorrectorParameters
to not generate data files in src tree ($CMSSW_BASE/src/CondFormats/JetMETObjects/data/
) but use unit tests area for these temp files.