Added TypeMatch to be used with GetterOfProducts

[Dr15Jones]

PR description:

This allows GetterOfProducts to completely emulate consumesMany.

PR validation:

The new unit tests pass.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34627

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34627/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34627/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34628

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57640c/31275/summary.html
COMMIT: f0c06a6
CMSSW: CMSSW_13_1_X_2023-03-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41054/31275/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar fix unit test: avoid creating data files in src tree #41044
• @beaucero HLT Phase2 Removing Duplicate Modules #40912
• @bmarzocc Customize to produce & save ECAL-only caloparticles #40986
• @dmeuser Update of HG PCL tracker alignment max movement thresholds #41041

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57640c/31275/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57640c/31275/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testFWCoreFrameworkGetByType_consumesMany had ERRORS
---> test testFWCoreFrameworkGetByType_getterOfProduct had ERRORS
---> test testFWCoreFrameworkGetByType_consumesMany_alias had ERRORS
---> test testFWCoreFrameworkGetByType_getterOfProduct_alias had ERRORS
and more ...

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 426 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550756
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550722
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@smuzaffar so the newly added unit tests followed your changes to the old unit tests. These tests ran fine in my local area by doing scram b runtests_<nameoftest> but they do not seem to work in the PR testing.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34632

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34632/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41054/34632/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

Pull request #41054 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[Dr15Jones]

@smuzaffar wrote

I can not find FWCore/Framework/test/test_get_by_type_cfg.py in repository. If it is a new file then may be you forgot to add it?

Ooops. I did fail to add it to the PR. Sorry about the noise.

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57640c/31293/summary.html
COMMIT: e5f06ff
CMSSW: CMSSW_13_1_X_2023-03-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41054/31293/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550756
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550721
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57640c/31299/summary.html
COMMIT: e5f06ff
CMSSW: CMSSW_13_1_X_2023-03-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41054/31299/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 16 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550756
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550728
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1