Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4VECGEOM] Update geant4 to 11.0.7 and dd4hep to 01.22 #8055

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_6_X/geant4_vecgeom.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27223/summary.html
COMMIT: bad7630
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8055/27223/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

Pull request #8055 was updated.

@cmsbuild
Copy link
Contributor

Pull request #8055 was updated.

@iarspider
Copy link
Contributor Author

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27227/summary.html
COMMIT: edabaf8
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8055/27227/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/src/FastSimulation/MaterialEffects/src/PairProductionSimulator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/src/FastSimulation/MaterialEffects/src/PetrukhinModel.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/geant4/11.0.7-455e16fefb11a175bd68a487e08c9750/include/Geant4/G4FTFParameters.hh:35,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/geant4/11.0.7-455e16fefb11a175bd68a487e08c9750/include/Geant4/G4FTFModel.hh:48,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/src/FastSimulation/MaterialEffects/src/NuclearInteractionFTFSimulator.cc:22:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/geant4/11.0.7-455e16fefb11a175bd68a487e08c9750/include/Geant4/G4FTFTunings.hh:158:5: error: missing braces around initializer for 'std::__array_traits::_Type' {aka 'G4String [10]'} [-Werror=missing-braces]
  158 |     };
      |     ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc10/external/geant4/11.0.7-455e16fefb11a175bd68a487e08c9750/include/Geant4/G4FTFTunings.hh:161:96: error: missing braces around initializer for 'std::__array_traits::_Type' {aka 'int [10]'} [-Werror=missing-braces]
  161 |     std::array< G4int, sNumberOfTunes > fApplicabilityOfTunes = { 1, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
      |                                                                                                ^


@civanch
Copy link
Contributor

civanch commented Aug 31, 2022

@iarspider , cms-externals/geant4#62 should resolve the problem.

@iarspider
Copy link
Contributor Author

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

Pull request #8055 was updated.

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27253/summary.html
COMMIT: 9354617
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8055/27253/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27253/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27253/git-merge-result

RelVals

  • 35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 28234.028234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

@civanch
Copy link
Contributor

civanch commented Sep 1, 2022

Problem report shows the problem we observed when use -O3 for VecGeom

@smuzaffar
Copy link
Contributor

@smuzaffar
Copy link
Contributor

-O3 for VecGeom is only enabled for gcc11 builds

@smuzaffar
Copy link
Contributor

by the way, one of these failed workflow also fail for IBs

@smuzaffar
Copy link
Contributor

test parameters:

  • full_cmssw = true

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27277/summary.html
COMMIT: 9354617
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-08-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8055/27277/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27277/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ef0ec/27277/git-merge-result

RelVals

  • 35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 28234.028234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

@smuzaffar smuzaffar merged commit 609d4a5 into IB/CMSSW_12_6_X/geant4_vecgeom Sep 2, 2022
@iarspider iarspider deleted the update-geant4-11.0.7-dd4hep-01-22-geant4_vecgeom branch September 2, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants