[L1T] fix asan runtime errors in DTTrigger Phase-2

[cecilecaillol]

PR description:

Addressing issue #39246 (ASAN runtime errors in DTTriggerPhase2)

[cecilecaillol]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39263/31909

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

• L1Trigger/DTTriggerPhase2 (upgrade, l1)

@epalencia, @AdrianoDee, @srimanob, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

Shouldn't this be tested with an ASAN build? e.g.

"please test for CMSSW_12_6_ASAN_X"

[smuzaffar]

please test workflow 23234.0,37434.0 for CMSSW_12_6_ASAN_X

lets run the tests for couple of failing workflows in ASAN build too

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7014bc/27225/summary.html
COMMIT: cb3b08a
CMSSW: CMSSW_12_6_ASAN_X_2022-08-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39263/27225/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @nhduongvn Add new data catalogs from Rucio storage description (RucioCatalog) and use it by default instead of trivial data catalogs (TrivialCatalog) #37278
• @makortel Add support for lambda ESProducer produce functions #39156
• @tahuang1991 Update the CSCStubMatcher and CSCDigiMatcher under Validation/MuonCSCDigis  #39155
• @smuzaffar [LTO] ODR warning fixed by moving MTDHit struct in to its own header file #39203
• @bsunanda Run3-gex138C Try to avoid getByLabel and instead use getByToken in a few modules of Calibration #39216
• @finnlabe Hlt gen validation #38593
• @mmusich Move DiMuonMassBiasClient to a regular harvesting path #39217
• @waredjeb TICL version 4: CLUE3D as default Pattern Recognition, Linking #38880
• @guitargeek Merge .h and .cc files of plugins in RecoLocalCalo/EcalRecProducers #39171
• @bsunanda Run3-gex138E Use getByToken instead of getByLabel in Calibration/EcalCalibAlgos #39241
• @lathomas Compute/store unprefirable event information by default in MINIAOD  #39169
• @mseidel42 MergedGenParticleProducer: insert photon mothers for pair-produced leptons #38995
• @slava77 return invalid planeCrossing to reference points with zero B-field in TrackKinematicStatePropagator #39183
• @dpilipov Adds FED ID 1405 for uGT Testcrate for L1T Ntuples #39104
• @mmusich get rid of more undefined behaviour in TrackListMerger #39233
• @vukasinmilosevic L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list #38840
• @bsunanda Run3-gex138D Use getByToken instead of getByLabel in CaloOnlineTools/EcalTools #39226

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7014bc/27225/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7014bc/27225/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

[perrotta]

type bugfix

[perrotta]

please test
(The previously failing workflows complete without errors now in ASN. Try to refresh tjhe "normal" tests, to recover from the pending tests staus in bot.)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7014bc/27251/summary.html
COMMIT: cb3b08a
CMSSW: CMSSW_12_6_X_2022-08-31-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39263/27251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3620448
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3620414
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[perrotta]

@cms-sw/upgrade-l2 we are trying to fix as many errors as possible in the IBs
This fix looks quite logic, and simple enough to be evaluated quickly: do you have anything to comment, or can we merge it (after your "+1")?

[srimanob]

Hi @perrotta
Is the error on cms/39263/ASAN/el8_amd64_gcc10/unittest expected? I assume not related to this PR.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

Hi @perrotta Is the error on cms/39263/ASAN/el8_amd64_gcc10/unittest expected? I assume not related to this PR.

Hi @srimanob
ASAN builds normally signal quite several errors. The ones that were supposed to be fixed by this PR are not there any more. And the "regular" build shows no errors, not even in the unit tests. This PR looks like having fixed #39246

[smuzaffar]

Hi @perrotta Is the error on cms/39263/ASAN/el8_amd64_gcc10/unittest expected? I assume not related to this PR.

yes unit tests here is not related to this change. unit tests fails in ASAN IBs too. basically system "cp" command fails when run under LD_PRELOAD=/cvmfs/cms-ib.cern.ch/nweek-02748/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/lib64/libasan.so . I guess we can disable this test for ASAN IBs