-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge .h and .cc files of plugins in RecoLocalCalo/EcalRecProducers
#39171
Conversation
Part of the series of PRs that merges `.h` files with the `.cc` files of the plugins in some CMSSW subsystems (see #35216 for the last one). It makes maintaining the plugins much easier and also excludes the possibility to wrongly include plugin header files. The changes made in this PR are only copy-paste and sorting includes to make the review easy.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39171/31760
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages:
@jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ddb9b/27116/summary.html Comparison SummarySummary:
|
@jpata any news on this one? |
+reconstruction
(10 lines of code = 10 issues. 500 lines of code = "looks fine." ref) |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Part of the series of PRs that merges
.h
files with the.cc
files ofthe plugins in some CMSSW subsystems (see #35216 for the last one).
It makes maintaining the plugins much easier and also excludes the
possibility to wrongly include plugin header files.
The changes made in this PR are only copy-paste and sorting includes to
make the review easy.
PR validation:
CMSSW compiles.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No backport intended.