Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop --catalog option from edmFileUtil check in unittestinputsource (online DQM unit tests) #39266

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 31, 2022

resolves #39262

PR description:

Title says it all, no longer needed after integration of #37278, as per #39262 (comment)

PR validation:

Will be done in the PR unit tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Aug 31, 2022

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39266/31915

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 31, 2022

please test

@perrotta
Copy link
Contributor

urgent
(mostly for us: there are too many errors in the IBs now, and we should really start getting rid of them)

@smuzaffar
Copy link
Contributor

looks good, unit tests passed

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-304308/27226/summary.html
COMMIT: 9a056d4
CMSSW: CMSSW_12_6_X_2022-08-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39266/27226/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3620448
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3620413
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • It looks like having fixed the issue: let merge it and try to clean the IBs a bit
  • @cms-sw/dqm-l2 please complain if you think there is anything missing

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 39bec54 into cms-sw:master Aug 31, 2022
@mmusich mmusich deleted the fixDQMUnitTests branch August 31, 2022 18:13
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DQM unit tests massive failures in CMSSW_12_6_X_2022-08-30-2300
5 participants