CRM-11926 Improve error message on APi failure to include DB error message #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore, doing a new branch with |
yashodha
pushed a commit
to yashodha/civicrm-core
that referenced
this pull request
Apr 7, 2013
worked on upgrade part CRM-12274
MegaphoneJon
pushed a commit
to MegaphoneJon/civicrm-core
that referenced
this pull request
Apr 30, 2013
CRM-12096 fix quickicon image for j3.0
ravishnair
pushed a commit
to ravishnair/civicrm-core
that referenced
this pull request
Jun 14, 2013
---------------------------------------- * CRM-12809: Reserved CustomGroups http://issues.civicrm.org/jira/browse/CRM-12809
Merged
kurund
added a commit
to kurund/civicrm-core
that referenced
this pull request
Jan 6, 2014
---------------------------------------- * CRM-14052: Tagset fixes http://issues.civicrm.org/jira/browse/CRM-14052
kurund
added a commit
to kurund/civicrm-core
that referenced
this pull request
Jan 6, 2014
---------------------------------------- * CRM-14052: Tagset fixes http://issues.civicrm.org/jira/browse/CRM-14052
Edzelopez
referenced
this pull request
in Edzelopez/civicrm-core
Feb 6, 2014
MISC-32 Added test for contribution_id
rohankatkar
pushed a commit
to rohankatkar/civicrm-core-master
that referenced
this pull request
May 22, 2014
VAT-365 Proposed Tax UI changes
yashodha
pushed a commit
to yashodha/civicrm-core
that referenced
this pull request
Sep 30, 2014
kurund
pushed a commit
to kurund/civicrm-core
that referenced
this pull request
May 12, 2015
Add default of current timestamp to the create_datek
davecivicrm
pushed a commit
that referenced
this pull request
Jul 21, 2015
Fixed spelling of 'memebership' in 625
totten
pushed a commit
that referenced
this pull request
Oct 14, 2015
CRM-17385 - CRM_Extension_BrowserTest
eileenmcnaughton
pushed a commit
that referenced
this pull request
Jun 7, 2016
Merge two patches into single patch.
samuelsov
added a commit
to samuelsov/civicrm-core
that referenced
this pull request
Jun 2, 2023
This was referenced Sep 18, 2023
This was referenced Jan 4, 2024
Closed
jmcclelland
added a commit
to jmcclelland/civicrm-core
that referenced
this pull request
Feb 13, 2024
[PHP Deprecation] explode(): Passing null to parameter civicrm#2 ($string) of type string is deprecated at /var/www/powerbase/sites/all/modules/civicrm/CRM/Utils/Mail/EmailProcessor.php:83
samuelsov
added a commit
to samuelsov/civicrm-core
that referenced
this pull request
Mar 1, 2024
francescbassas
added a commit
to francescbassas/civicrm-core
that referenced
this pull request
Apr 2, 2024
…st be of type array, null given a CRM_Core_DAO->copyValues()
colemanw
added a commit
that referenced
this pull request
Apr 2, 2024
Fix for `TypeError: array_key_exists(): Argument #2 ($array) must be …
AurelieFoucher
pushed a commit
to agencenous/civicrm-core
that referenced
this pull request
May 16, 2024
This was referenced Jun 19, 2024
totten
pushed a commit
that referenced
this pull request
Sep 5, 2024
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
demeritcowboy
pushed a commit
that referenced
this pull request
Mar 7, 2025
In E2E\AfformMock\MockPublicFormTest, it attempts to submit form as an anonymous user. On a new/clean instance of D9/D10 with php83, the test fails consistently. BEFORE: The submission is rejected. In the Drupal log, we see a corresponding error: TypeError: CRM_Utils_System_Drupal8::isMaintenanceMode(): Return value must be of type bool, null returned in CRM_Utils_System_Drupal8->isMaintenanceMode() (line 1023 of /home/totten/bknix/build/build-0/src/civicrm-core/CRM/Utils/System/Drupal8.php). - #0 /home/totten/bknix/build/build-0/src/civicrm-core/CRM/Utils/System.php(1952): CRM_Utils_System_Drupal8->isMaintenanceMode() - #1 /home/totten/bknix/build/build-0/src/civicrm-core/CRM/Api4/Page/AJAX.php(28): CRM_Utils_System::isMaintenanceMode() - #2 /home/totten/bknix/build/build-0/src/civicrm-core/CRM/Core/Invoke.php(278): CRM_Api4_Page_AJAX->run(Array, NULL) - #3 /home/totten/bknix/build/build-0/src/civicrm-core/CRM/Core/Invoke.php(73): CRM_Core_Invoke::runItem(Array) AFTER: It's ok. TECHNICAL DETAILS: On a new/clean system, the content of `system.maintenance_mode` appears to be `NULL`. The bug is likely hard to see in manual testing because: 1. A lot of manual testing is done as admin user (who can bypass maintence-mode checks). 2. After you've toggled maintenance-mode for the first, the value becomes `0` or `1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should be the right one