Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.x: fix TypeError in config hook #27996

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Nov 2, 2023

Overview

Using vanilla CiviCRM with the old ckeditor 4, attempting to upload a file results in a fatal TypeError on PHP 8.0 and later.

To reproduce:

Before

TypeError: array_merge(): Argument #2 must be of type array, null given in array_merge() (line 1490 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php).

After

no error

Technical Details

Changing the function definition to default to $flags = [] didn't seem to help, so I opted for an ugly fix.

I opened this PR against the RC, because it's a fatal PHP 8 bug.

Copy link

civibot bot commented Nov 2, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Nov 2, 2023
@mlutfy mlutfy changed the base branch from master to 5.68 November 2, 2023 19:55
@civibot civibot bot added 5.68 and removed master labels Nov 2, 2023
@colemanw
Copy link
Member

colemanw commented Nov 2, 2023

IMO we could also do this for 5.67 since there's already been one regression fix merged into that branch since yesterday's release.

@totten
Copy link
Member

totten commented Nov 2, 2023

Agree with @colemanw, we should also backport. Added #27998.

@seamuslee001 seamuslee001 merged commit bdce497 into civicrm:5.68 Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants