Merge from master #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a service named 'angularjs.loader' to manage multiple angular apps on the page. Because <ng-app> can only be used once per page, a new tag, <crm-angular-js> has been created.
Remove deprecated code
[REF] [Towards membership api] Simplify calculation of recurring membership parameters
Note this will test fail on 3 things that worked with the other. The way in which we load tokens means that some values have been exposed that possibly would be better not exposed - but we can either remove them from advertised tokens, fix the tokenCompat class to support them or possibly deprecate by removing from the UI display but continuing to handle. One notable difference is the contact_reference entity id.
… contact record Also removes the possibility to set a user-defined password for WordPress users.
[PHPunit8] cleanup on setUp functions
Update flexmailer default
PHPUNIT 8 - add void to setup functions
dev/core#2243 Add created_date column to the civicrm_note table
This adds the same mechanism as the group contact cache to reduce site contention. A job api is also added which people can optionally configure. It would be especially worth setting on sites that do not use ACLs at all
dev/financial#171 - False INTL warning when adding a price field
dev/core#2477 Add setting to allow opportunistic cache flushing for acls
dev/core#2486 Add entity financial trxn
There is little value in getting the aggregate contributions if failed contributions are also included.
SearchKit - Flush Angular cache when saving
5.37 to master
Use propertyBag in doPayment
Make it clear that doDirectPayment/doTransferCheckout are deprecated …
dev/report#58 SearchKit - Rename 'Filters' to 'Having' for clarity
5.37 to master
Add installments to propertyBag
…nt/doTransferCheckout
Initial refactor of PayPal core processor to stop using doDirectPayment/doTransferCheckout
Use standard function to add reCAPTCHA to PCPAccount form
Add amount as standard property to PaymentPropertyBag
…n page when coming from a shortcode which leads to infinite redirect loop if session timesout Add in comment and expand fix to cover event registratons as well
[REF] Simplify interaction with contributionRecur
…n to propertyBag without hitting legacy warnings on unconverted payment processors
[REF] Fix error where entryURL does not contain id of the contributio…
Suppress legacy warnings by default in propertyBag to allow transition to propertyBag without hitting legacy warnings on unconverted payment processors
Convert Dummy payment processor to use doPayment function
- Adds a separate category of ContactLayout block per afform-type - Adds a helper function to getFields so non-dao entities can load options from an optionGroup - Renames search display afforms to "Search Form" to distinguish them from actual search displays
This fixes an undefined index notice for permissions that use the new-style 'label' and 'description' array keys instead of numeric keys.
APIv4 - Fix unserialize settings
Afform - Improve integration with ContactLayout editor
Update WP permission page for new string array keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note