dev/financial#171 - False INTL warning when adding a price field

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/financial/-/issues/171#note_56522

1. Turn off popups. (You don't have to but you won't see the message as easily.)
2. Make a membership type and leave minimum fee blank.
3. Make a price set for memberships.
4. Add a price field and make it a radio or select.
5. In the option choice rows there's a dropdown for the type. Pick the type you made.
6. What's supposed to happen is the row is supposed to autofill. It doesn't.
7. Click cancel.
8. Message about missing INTL even though it's installed.

Before

False warning about missing INTL extension.
Hidden php type error.
Row doesn't autofill.

After

Good.

Technical Details

The field allows both null and 0. A blank gets stored as null, but then is_numeric is false when it tries to round it and the INTL message comes up when is_numeric is false. There's also then a type error which causes the ajax call to 500, so it doesn't autofill.

Comments

The second change is something not used at this point on the form but is clearly wrong and gives its own warning. It's been like that for about 8 years.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Wow that last one survived a while