CRM-18397: Blank billing address created on paid event registrations with no billing address

[rohankatkar]

https://issues.civicrm.org/jira/browse/CRM-18397

[rohankatkar]

jenkins, retest this please

[rohankatkar]

@JKingsnorth, following cases are covered in this PR:

1. Event registration with 'external' payment processor.
2. Event registration with 'pay_later' and 'isBillingAddressRequiredForPayLater'.

[JKingsnorth]

Manual testing does not pass, commented on JIRA.

[rohankatkar]

@JKingsnorth , I agree with your comment which you've mentioned on JIRA. If you changed any information for contact it does not update.

This PR changes only fixes the following scenario:

1. If you made a payment via external payment processor (here I am creating test contribution via 'PayPal Pro'), then it does not ask to fill billing address field as it redirects to the pay pal. After creating contribution, there is no blank billing address is added on contact summary page (no billing address section on contact summary page).

2. As mentioned the case CRM-11926 Improve error message on APi failure to include DB error message #2 above in my comment, we also need to handle the case if 'pay_later' and 'isBillingAddressRequiredForPayLater' is set to true. In this case, if you changed any information for contact then, it gets updated. And of course 'Billing Address' is added for that contact.

I have also tested with your PR (#8122). As you mentioned in issue description, if we don't ask for billing details on the form, then we don't want to store them in Civi. So don't create a blank billing address.

In your PR, if I create contribution via external payment processor, then its added blank 'Billing Address' on contact summary page only with billing names and empty address fields. I think this is odd.

So, I think as you mentioned in comment on JIRA, need to handle changes to updates contact information.

[JKingsnorth]

I'll take another look at the other PR. On my last testing it didn't create the blank billing details, but I'll re-check with a couple of external providers to see what the problem is - thanks for the feedback.

I'll also take a look at it in the context of 'pay later' with the 'billing address required' setting that you mention.

I'll take a look at this as soon as I can tomorrow. Thanks again.

[rohankatkar]

@JKingsnorth, I have updated a PR for following scenarios:

1. Event registration with 'external' payment processor.
2. If an authenticated user makes the contribution then, contact fields are getting updated (e.g Email Address, Contact name).
3. If an anonymous user registers for an event then, a new contact is created.
4. If 'pay_later' and 'isBillingAddressRequiredForPayLater' is set to true, then, billing address is updated or added for that contact.

can you please check if PR satisfies above scenarios?

[monishdeb]

It looks redundant as the above code 469-494 does the same job - unset billing address field (should have extended the above IF condition to do the same). Also looks like we are simply wiping out the billing address without a criteria this might affect payment processor which require billing address.

[JKingsnorth]

I also have a bit of a vendetta against 'lists of fields' in Civi that are manually typed out like this. They are quite hard to maintain. I'll take another look at this in the alternate PR.

[rohankatkar]

@JKingsnorth, I am using 'PayPal - Website Payments Pro' processor for testing.
I think, statndard solution would be just do not create billing address for contact, if billing address fields are empty.

I am closing this PR, because it may affect other use-cases where billing address is required in case of other external payment processor. you can cherry-pick my commit if its helpful.

[magnolia61]

Am I correct this PR is not merged? Any chance it will be?

[JKingsnorth]

@magnolia61 Would you be able to test the other PR we've proposed? #8122 If it works for you then that would be a good bit of review. If you find any issues then do let us know on the issue on JIRA, or on that PR.