CRM-18397: Don't add empty billing name to non-existent billing address

[JKingsnorth]

• CRM-18397: Blank billing address created on paid event registrations with no billing address

[monishdeb]

@JKingsnorth can I close this in favor of #8176 ?

[JKingsnorth]

Well at the moment this solution is more functional than the other. It depends if the QAers want to refine the other PR or if they have any comments for me to improve on this one.

[monishdeb]

Sorry for delay, seems like rohan has already made some changes in his PR #8176 on some of the flaw you mentioned in the ticket itself.

[eileenmcnaughton]

Accepting this makes me die a little inside. I would so much prefer to consolidate with

$this->formatParamsForPaymentProcessor($fields);

(used by the contribute form)

And to resolve all those questions on why we add & drop billing filling fields like they are participants in a boy band.

However, I realise I'm not game to turn this into the PR I really want to do this time around - not least because we don't have CI tests on event forms yet.

So, perhaps as a compromise we could just brutalise the code with comments.

[eileenmcnaughton]

This function is largely a duplicate of the contribution function

$fields = $this->formatParamsForPaymentProcessor($fields);

However, there is a possible case where the syntax might diverge when dealing with multiple participants.

In general the contribution code is cleaner because rather than coming up with 100 & one conditions as to why we add or remove the billing fields it simply assumes that if we presented them on the form in the first place then we probably did so in order to save them

[eileenmcnaughton]

Merged! Your comments are so polite too...