Revert staged generator PRs #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will also resolve this SO ticket: |
|
It should, but as Wes diagnosed, we will want to fix this in ChiselStage in the future, since we want to un-revert these changes ASAP as well. |
colinschmidt
approved these changes
Mar 10, 2020
debs-sifive
added a commit
that referenced
this pull request
Mar 16, 2020
This reverts commit e170f8f.
debs-sifive
added a commit
that referenced
this pull request
Mar 25, 2020
This reverts commit e170f8f.
debs-sifive
added a commit
that referenced
this pull request
Apr 6, 2020
ucbjrl
added a commit
that referenced
this pull request
Apr 21, 2020
Revert staged generator PRs (#2329) * Revert "updating README examples with Make changes (#2322)" This reverts commit 875dcd3. * Revert "fixing aspect generation (#2309)" This reverts commit bbeb257. * Revert "separate generator behavior into phases (#2274)" This reverts commit 9d99750. (cherry picked from commit e170f8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2322 #2309 #2274
Type of change:other enhancement
Impact: API modification - use prior Makefile conventions
Development Phase: implementation
Release Notes
This is causing backwards compatibility issues. Will be re-PRed in the future.