Remove extended_email_reply_parser dependency
#1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason `extended_email_reply_parser` was added as a dependency to the main `bullet_train` gem even though it's not used anywhere in `core` or in the starter repo. It _is_ used by `bullet_train-conversations` and is declared as a dependency there, so we don't need it here. `extended_email_reply_parser` relies on `charlock_holmes` which is notoriously finicky to install due to native extensions. Removing this dependency should eliminate one of the big problems that people often run into when first setting up Bullet Train. Fixes #999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
extended_email_reply_parserwas added as a dependency to the mainbullet_traingem even though it's not used anywhere incoreor in the starter repo.It is used by
bullet_train-conversationsand is declared as a dependency there, so we don't need it here.extended_email_reply_parserrelies oncharlock_holmeswhich is notoriously finicky to install due to native extensions. Removing this dependency should eliminate one of the big problems that people often run into when first setting up Bullet Train.Fixes #999