Remove extended_email_reply_parser dependency (#1002)

* Remove `extended_email_reply_parser` dependency For some reason `extended_email_reply_parser` was added as a dependency to the main `bullet_train` gem even though it's not used anywhere in `core` or in the starter repo. It _is_ used by `bullet_train-conversations` and is declared as a dependency there, so we don't need it here. `extended_email_reply_parser` relies on `charlock_holmes` which is notoriously finicky to install due to native extensions. Removing this dependency should eliminate one of the big problems that people often run into when first setting up Bullet Train. Fixes #999 * Oops missed one * Need to define another teplate method * linter
bullet-train-co · Dec 30, 2024 · 33c2218 · 33c2218
1 parent 02d80ec
commit 33c2218
Show file tree

Hide file tree

Showing 14 changed files with 4 additions and 92 deletions.
diff --git a/bullet_train-api/Gemfile.lock b/bullet_train-api/Gemfile.lock
@@ -68,7 +68,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -197,7 +196,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -226,14 +224,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-fields/Gemfile.lock b/bullet_train-fields/Gemfile.lock
@@ -74,7 +74,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -197,7 +196,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -229,14 +227,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-incoming_webhooks/Gemfile.lock b/bullet_train-incoming_webhooks/Gemfile.lock
@@ -83,7 +83,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -205,7 +204,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -234,14 +232,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     factory_bot_rails (6.4.4)

diff --git a/bullet_train-integrations-stripe/Gemfile.lock b/bullet_train-integrations-stripe/Gemfile.lock
@@ -92,7 +92,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -215,7 +214,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -244,14 +242,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-outgoing_webhooks/Gemfile.lock b/bullet_train-outgoing_webhooks/Gemfile.lock
@@ -83,7 +83,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -204,7 +203,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -233,14 +231,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-sortable/Gemfile.lock b/bullet_train-sortable/Gemfile.lock
@@ -83,7 +83,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -203,7 +202,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -232,14 +230,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/...authorize_resource/app/controllers/concerns/bullet_train/loads_and_authorizes_resource.rb b/...authorize_resource/app/controllers/concerns/bullet_train/loads_and_authorizes_resource.rb
@@ -200,4 +200,8 @@ def create
   def update
     raise "This is a template method that needs to be implemented by controllers including LoadsAndAuthorizesResource."
   end
+
+  def destroy
+    raise "This is a template method that needs to be implemented by controllers including LoadsAndAuthorizesResource."
+  end
 end
diff --git a/bullet_train-super_scaffolding/Gemfile.lock b/bullet_train-super_scaffolding/Gemfile.lock
@@ -74,7 +74,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -197,7 +196,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -226,14 +224,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-themes-light/Gemfile.lock b/bullet_train-themes-light/Gemfile.lock
@@ -90,7 +90,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -212,7 +211,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -241,14 +239,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-themes-tailwind_css/Gemfile.lock b/bullet_train-themes-tailwind_css/Gemfile.lock
@@ -83,7 +83,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -204,7 +203,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -233,14 +231,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train-themes/Gemfile.lock b/bullet_train-themes/Gemfile.lock
@@ -75,7 +75,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -197,7 +196,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -227,14 +225,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train/Gemfile.lock b/bullet_train/Gemfile.lock
@@ -105,7 +105,6 @@ PATH
       commonmarker (>= 1.0.0)
       devise
       devise-pwned_password
-      extended_email_reply_parser
       fastimage
       figaro
       hiredis
@@ -219,7 +218,6 @@ GEM
       railties (>= 5.2)
       thread-local (>= 1.1.0)
     cancancan (3.6.1)
-    charlock_holmes (0.7.9)
     chronic (0.10.2)
     cloudinary (2.2.0)
       faraday (>= 2.0.1, < 3.0.0)
@@ -252,14 +250,8 @@ GEM
     doorkeeper (5.8.1)
       railties (>= 5)
     drb (2.2.1)
-    email_reply_parser (0.5.11)
     erubi (1.13.1)
     event_stream_parser (1.0.0)
-    extended_email_reply_parser (0.5.1)
-      activesupport
-      charlock_holmes
-      email_reply_parser (~> 0.5.9)
-      mail
     factory_bot (6.5.0)
       activesupport (>= 5.0.0)
     faraday (2.12.2)

diff --git a/bullet_train/bullet_train.gemspec b/bullet_train/bullet_train.gemspec
@@ -90,9 +90,6 @@ Gem::Specification.new do |spec|
   # Allow users to supply content with markdown formatting. Powers our markdown() view helper.
   spec.add_dependency "commonmarker", ">= 1.0.0"
 
-  # Extract the body from emails received using action inbox.
-  spec.add_dependency "extended_email_reply_parser" # TODO ➡️ `bullet_train-conversations`
-
   # OpenAI
   spec.add_dependency "ruby-openai"
 

diff --git a/bullet_train/lib/bullet_train.rb b/bullet_train/lib/bullet_train.rb
@@ -32,7 +32,6 @@
 require "figaro"
 require "valid_email"
 require "commonmarker"
-require "extended_email_reply_parser"
 require "pagy"
 require "devise/pwned_password"
 require "openai"